Skip to content

Tweak the delta used for vector scorer tests #126849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Apr 15, 2025

Make the delta scale with the number of dimensions (the more dims, the more inaccurate FP can be)

Fixes #126847, fixes #126797

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search labels Apr 15, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0 labels Apr 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@thecoop thecoop merged commit 1f249c7 into elastic:main Apr 15, 2025
14 of 18 checks passed
@thecoop thecoop deleted the vector-scorer-test-delta branch April 15, 2025 14:46
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Apr 16, 2025
New panama operations in Lucene 10.2 change the results we get from vector operations slightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
3 participants