Add descriptions to assertions in testMetrics #102386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#101608 we saw one of these assertions fail, but it's impossible to know which one without some more details. This commit adds descriptions to the assertions in the loop.
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
kingherc
approved these changes
Nov 20, 2023
...c/internalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
Outdated
Show resolved
Hide resolved
...c/internalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Iraklis Psaroudakis <[email protected]>
DaveCTurner
added
the
auto-merge-without-approval
|
I left that out since you can determine which assertion tripped from the line numbers. But happy to add them too. |
DaveCTurner
deleted the
2023/11/20/S3-testMetrics-assertion-descriptions
branch
DaveCTurner
restored the
2023/11/20/S3-testMetrics-assertion-descriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #101608 we saw one of these assertions fail, but it's impossible to
know which one without some more details. This commit adds descriptions
to the assertions in the loop.