Skip to content

Add descriptions to assertions in testMetrics #102386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Add descriptions to assertions in testMetrics #102386

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8708317
Add descriptions to assertions in testMetrics
DaveCTurner Nov 20, 2023
70dece7
Apply suggestions from code review
DaveCTurner Nov 20, 2023
55fcc32
Merge branch 'main' into 2023/11/20/S3-testMetrics-assertion-descript…
DaveCTurner Nov 20, 2023
08e0b09
Spotless
DaveCTurner Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Spotless
  • Loading branch information
@DaveCTurner
DaveCTurner committed Nov 20, 2023
commit 08e0b09e5d3cba1a44a3d5e15c89e3dce4cce74b
6 changes: 5 additions & 1 deletion ...nternalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,11 @@ public void testMetrics() throws Exception {
OperationPurpose.parse((String) metric.attributes().get("purpose"))
);
assertThat(nodeName + "/" + statsKey + " exists", statsCollectors, hasKey(statsKey));
assertThat(nodeName + "/" + statsKey + " has correct sum", metric.getLong(), equalTo(statsCollectors.get(statsKey).counter.sum()));
assertThat(
nodeName + "/" + statsKey + " has correct sum",
metric.getLong(),
equalTo(statsCollectors.get(statsKey).counter.sum())
);

aggregatedMetrics.compute(operation.getKey(), (k, v) -> v == null ? metric.getLong() : v + metric.getLong());
});
Expand Down