Skip to content

Add test logging to S3BlobStoreRepositoryTests#testMetrics #102387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add test logging to S3BlobStoreRepositoryTests#testMetrics #102387

merged 1 commit into from
Nov 20, 2023

Conversation

DaveCTurner
Copy link
Contributor

Relates #101608

@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.12.0 labels Nov 20, 2023
@DaveCTurner DaveCTurner requested a review from fcofdez November 20, 2023 16:44
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 20, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

kingherc
kingherc approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 20, 2023
@elasticsearchmachine elasticsearchmachine merged commit 7cc711a into elastic:main Nov 20, 2023
@DaveCTurner DaveCTurner deleted the 2023/11/20/S3BlobStoreRepositoryTests-test-logging branch November 20, 2023 17:22
@DaveCTurner DaveCTurner mentioned this pull request Nov 21, 2023
Closed
@DaveCTurner DaveCTurner restored the 2023/11/20/S3BlobStoreRepositoryTests-test-logging branch June 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingherc kingherc kingherc approved these changes

@fcofdez fcofdez Awaiting requested review from fcofdez

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @kingherc