Skip to content

Add test logging to S3BlobStoreRepositoryTests#testMetrics #102387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add test logging to S3BlobStoreRepositoryTests#testMetrics #102387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add test logging to S3BlobStoreRepositoryTests#testMetrics 
Relates #101608
  • Loading branch information
@DaveCTurner
DaveCTurner committed Nov 20, 2023
commit f19baa64afbd25a9603ff46ddb92b60f39b762d0
5 changes: 3 additions & 2 deletions ...nternalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
import org.elasticsearch.telemetry.metric.MeterRegistry;
import org.elasticsearch.test.BackgroundIndexer;
import org.elasticsearch.test.ESIntegTestCase;
import org.elasticsearch.test.junit.annotations.TestLogging;
import org.elasticsearch.test.junit.annotations.TestIssueLogging;
import org.elasticsearch.threadpool.ThreadPool;
import org.elasticsearch.xcontent.NamedXContentRegistry;
import org.elasticsearch.xcontent.XContentFactory;
Expand Down Expand Up @@ -179,7 +179,7 @@ protected Settings nodeSettings(int nodeOrdinal, Settings otherSettings) {
}

@Override
@TestLogging(reason = "Enable request logging to debug #88841", value = "com.amazonaws.request:DEBUG")
@TestIssueLogging(issueUrl = "https://github.com/elastic/elasticsearch/issues/88841", value = "com.amazonaws.request:DEBUG")
public void testRequestStats() throws Exception {
super.testRequestStats();
}
Expand Down Expand Up @@ -225,6 +225,7 @@ public void testAbortRequestStats() throws Exception {
assertEquals(assertionErrorMsg, mockCalls, sdkRequestCounts);
}

@TestIssueLogging(issueUrl = "https://github.com/elastic/elasticsearch/issues/101608", value = "com.amazonaws.request:DEBUG")
public void testMetrics() throws Exception {
// Create the repository and perform some activities
final String repository = createRepository(randomRepositoryName());
Expand Down