-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[Entitlements] Fixing reindex policy #123599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Entitlements] Fixing reindex policy #123599
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
- files: | ||
- relative_path: "" | ||
- relative_path_setting: "reindex.ssl.certificate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjernst I have no idea if I'm using this correctly, as this is the first time we use it I think.
Will this work with exclusive access?
Can I use a glob (reindex.ssl.*) instead?
certificate_authorities
is a list; will that work with your file settings implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work if the setting is a list, we resolve all paths, whether for a single setting, or multiple settings. It should also work with exclusive. Also note the properties are changing per our earlier discussion, see #123649.
But it's curious that we didn't need this before? I guess it would have only worked if it was relative to the config dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note the properties are changing per our earlier discussion, see #123649.
Thanks! So reindex.ssl.*
should work? I'll try it/look at logs/debug what it resolves to. Or maybe I'll write a test for it.
I'll update this to use the new properties after that is merged.
Relates to ES-10031