-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[Entitlements] Fixing reindex policy #123599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ldematte
wants to merge
4
commits into
elastic:main
Choose a base branch
from
ldematte:entitlements/missing-policies-reindex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−0
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2836cee
Fixing reindex policy
ldematte 4074432
Merge remote-tracking branch 'upstream/main' into entitlements/missin…
ldematte d324cdd
update to the new path settings keywords
ldematte b407995
Merge branch 'main' into entitlements/missing-policies-reindex
ldematte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 14 additions & 1 deletion
15
modules/reindex/src/main/plugin-metadata/entitlement-policy.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,20 @@ | ||
| ALL-UNNAMED: | ||
| - manage_threads | ||
| - outbound_network | ||
| - create_class_loader # needed for Painless to generate runtime classes | ||
| - files: | ||
| - relative_path: "" | ||
| - relative_path_setting: "reindex.ssl.certificate" | ||
| relative_to: config | ||
| mode: read | ||
| - relative_path_setting: "reindex.ssl.key" | ||
| relative_to: config | ||
| mode: read | ||
| - relative_path_setting: "reindex.ssl.keystore.path" | ||
| relative_to: config | ||
| mode: read | ||
| - relative_path_setting: "reindex.ssl.certificate_authorities" | ||
| relative_to: config | ||
| mode: read | ||
| - relative_path_setting: "reindex.ssl.truststore.path" | ||
| relative_to: config | ||
| mode: read | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjernst I have no idea if I'm using this correctly, as this is the first time we use it I think.
Will this work with exclusive access?
Can I use a glob (reindex.ssl.*) instead?
certificate_authoritiesis a list; will that work with your file settings implementation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work if the setting is a list, we resolve all paths, whether for a single setting, or multiple settings. It should also work with exclusive. Also note the properties are changing per our earlier discussion, see #123649.
But it's curious that we didn't need this before? I guess it would have only worked if it was relative to the config dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! So
reindex.ssl.*should work? I'll try it/look at logs/debug what it resolves to. Or maybe I'll write a test for it.I'll update this to use the new properties after that is merged.