Skip to content

[Failure Store] ES|QL security tests #125586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Mar 25, 2025

Some basic coverage for ES|QL security with failure store access. The behavior w.r.t. status codes diverges quite a bit between ES|QL and _search but not in any failure store specific way. ES|QL has the same authorization behavior when querying multiple data streams without failure store access in the mix.

@n1v0lg n1v0lg added >test Issues or PRs that are addressing/adding tests :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Mar 25, 2025
@n1v0lg n1v0lg self-assigned this Mar 25, 2025
@n1v0lg n1v0lg added the Team:Security Meta label for security team label Apr 8, 2025
@n1v0lg n1v0lg marked this pull request as ready for review April 8, 2025 12:01
@n1v0lg n1v0lg requested a review from slobodanadamovic April 8, 2025 12:01
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@n1v0lg n1v0lg added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 15, 2025
@elasticsearchmachine elasticsearchmachine merged commit add0f24 into elastic:main Apr 15, 2025
22 checks passed
@n1v0lg n1v0lg deleted the failure-store-esql-security-tests branch April 15, 2025 16:16
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

elasticsearchmachine pushed a commit that referenced this pull request Apr 15, 2025
Some basic coverage for ES|QL security with failure store access. The
behavior w.r.t. status codes diverges quite a bit between ES|QL and
_search but not in any failure store specific way. ES|QL has the same
authorization behavior when querying multiple data streams without
failure store access in the mix.
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Apr 16, 2025
Some basic coverage for ES|QL security with failure store access. The
behavior w.r.t. status codes diverges quite a bit between ES|QL and
_search but not in any failure store specific way. ES|QL has the same
authorization behavior when querying multiple data streams without
failure store access in the mix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants