Skip to content

[Failure Store] Test scroll API #126197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

slobodanadamovic
Copy link
Contributor

Adding basic test coverage for scroll API.

@slobodanadamovic slobodanadamovic added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label Team:Security Meta label for security team auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Apr 3, 2025
@slobodanadamovic slobodanadamovic requested a review from n1v0lg April 3, 2025 10:28
@slobodanadamovic slobodanadamovic self-assigned this Apr 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@slobodanadamovic slobodanadamovic changed the title Test scroll searches against failure store [Failure Store] Test scroll API Apr 3, 2025
Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- heads up: I'm merging #125586 so there may be some merge conflicts after 🙈 Sorry!

…re-store-test-scroll

# Conflicts:
#	x-pack/plugin/security/qa/security-trial/src/javaRestTest/java/org/elasticsearch/xpack/security/failurestore/FailureStoreSecurityRestIT.java
@slobodanadamovic slobodanadamovic added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 16, 2025
@elasticsearchmachine elasticsearchmachine merged commit 8c9a091 into elastic:main Apr 16, 2025
22 checks passed
@slobodanadamovic slobodanadamovic deleted the sa-failure-store-test-scroll branch April 16, 2025 12:30
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Apr 16, 2025
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants