ESQL: make AttributeMap and AttributeSet immutable
#125938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow reusing them in the plan analysis and skip recreating them in UnaryPlan/UnaryExec.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @bpintea, I've created a changelog YAML for you. |
15 tasks
costin
approved these changes
Apr 2, 2025
| @@ -249,7 +260,7 @@ public boolean isEmpty() { | |||
|
|
|||
| @Override | |||
| public boolean containsKey(Object key) { | |||
| return key instanceof NamedExpression ne ? delegate.containsKey(new AttributeWrapper(ne.toAttribute())) : false; | |||
| return key instanceof NamedExpression ne && delegate.containsKey(new AttributeWrapper(ne.toAttribute())); | |||
|
To keep the semantics in place, I would look into backporting this to 8.18, 8.19 and 9.0 as well - it will make maintenance a lot easier. |
bpintea
added
>refactoring
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Apr 3, 2025
This will allow reusing them in the plan analysis and skip recreating them in UnaryPlan/UnaryExec when not needed. Introduce/adjust builders for them, which are now the only way to use a modifiable map/set. Related elastic#124395 (cherry picked from commit 2b512bc)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 3, 2025
#126207) * ESQL: make `AttributeMap` and `AttributeSet` immutable (#125938) This will allow reusing them in the plan analysis and skip recreating them in UnaryPlan/UnaryExec when not needed. Introduce/adjust builders for them, which are now the only way to use a modifiable map/set. Related #124395 (cherry picked from commit 2b512bc) * Update 9.0-specific AttributeSet usage
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Apr 3, 2025
This will allow reusing them in the plan analysis and skip recreating them in UnaryPlan/UnaryExec when not needed. Introduce/adjust builders for them, which are now the only way to use a modifiable map/set. Related elastic#124395 (cherry picked from commit 2b512bc)
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
This will allow reusing them in the plan analysis and skip recreating them in UnaryPlan/UnaryExec when not needed. Introduce/adjust builders for them, which are now the only way to use a modifiable map/set. Related elastic#124395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow reusing them in the plan analysis and skip recreating them in
UnaryPlan/UnaryExecwhen not needed.Introduce/adjust builders for them, which are now the only way to use a modifiable map/set.
Related #124395