-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ML] Adding timeout to request for creating inference endpoint #126805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonathan-buttner
merged 8 commits into
elastic:main
from
jonathan-buttner:ml-support-timeout-put-inference
May 6, 2025
Merged
[ML] Adding timeout to request for creating inference endpoint #126805
jonathan-buttner
merged 8 commits into
elastic:main
from
jonathan-buttner:ml-support-timeout-put-inference
May 6, 2025
+84
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @jonathan-buttner, I've created a changelog YAML for you. |
…rt-timeout-put-inference
davidkyle
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rt-timeout-put-inference
Pinging @elastic/ml-core (Team:ML) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
May 6, 2025
…out to request (elastic#126805) * Fixing bug with listener and adding timeout * Update docs/changelog/126805.yaml * Fixing tests * Fixing writeTo (cherry picked from commit 4c507e2) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
backport pending
>bug
:ml
Machine learning
Team:ML
Meta label for the ML team
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds the
timeout
query parameter to the PUT request so users can specify a longer timeout than the default 30 seconds. 30 seconds was used previously based on the ack timeout for the master node.The timeout only applies to the start deployment request and the inference request during validation. The model download request ignores the timeout because it waits for the model to finish downloading before responding on the listener.
Testing
This request should result in a failure like the following