[ML] Adding missing onFailure call for Inference API start model request #126930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>bug
:ml
|
Hi @jonathan-buttner, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
dan-rubinstein
approved these changes
Apr 16, 2025
This was referenced Apr 16, 2025
Merged
Merged
Merged
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Apr 16, 2025
…est (elastic#126930) * Adding missing onFailure call * Update docs/changelog/126930.yaml
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Apr 16, 2025
…est (elastic#126930) * Adding missing onFailure call * Update docs/changelog/126930.yaml
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Apr 16, 2025
…est (elastic#126930) * Adding missing onFailure call * Update docs/changelog/126930.yaml
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Apr 16, 2025
…est (elastic#126930) * Adding missing onFailure call * Update docs/changelog/126930.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was discovered when adding a
timeoutquery parameter. When an error was being returned while starting the deployment if it wasn't a conflict it wasn't being returned on the listener because we were missing anonFailurecall.The PR to add the timeout is here: #126805 I split the bug fix out so that it's easier to backport.