-
Notifications
You must be signed in to change notification settings - Fork 25.2k
RepositoryAnalysisFailureIT: disrupt earlier #127032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes elastic#127029 The fix to elastic#126747 was only for one test. This applies that change to all the tests in this suite that need it.
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we extract a method:
private static CountDown createDisruptionCountdown(RepositoryAnalyzeAction.Request request) {
// requests that create copies count as two blobs. Halving the count ensures that we trigger the disruption
// even if every request is a copy
return new CountDown(between(1, request.getBlobCount() / 2));
}
That way we won't leave readers confused about the / 2
.
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The fix to #126747 was only for one test. This applies that change to all the tests in this suite that need it.
Fixes #127029