Skip to content

RepositoryAnalysisFailureIT: disrupt earlier #127032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025
Merged

Conversation

bcully
Copy link
Contributor

@bcully bcully commented Apr 17, 2025

The fix to #126747 was only for one test. This applies that change to all the tests in this suite that need it.

Fixes #127029

Fixes elastic#127029

The fix to elastic#126747 was only for one test. This applies
that change to all the tests in this suite that need it.
@bcully bcully added >test Issues or PRs that are addressing/adding tests v9.1.0 :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. labels Apr 17, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Apr 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we extract a method:

    private static CountDown createDisruptionCountdown(RepositoryAnalyzeAction.Request request) {
        // requests that create copies count as two blobs. Halving the count ensures that we trigger the disruption
        // even if every request is a copy
        return new CountDown(between(1, request.getBlobCount() / 2));
    }

That way we won't leave readers confused about the / 2.

@bcully
Copy link
Contributor Author

bcully commented Apr 17, 2025

Could we extract a method:

    private static CountDown createDisruptionCountdown(RepositoryAnalyzeAction.Request request) {
        // requests that create copies count as two blobs. Halving the count ensures that we trigger the disruption
        // even if every request is a copy
        return new CountDown(between(1, request.getBlobCount() / 2));
    }

That way we won't leave readers confused about the / 2.

Sure.

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcully bcully merged commit 26254e3 into elastic:main Apr 18, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] RepositoryAnalysisFailureIT testFailsOnReadError failing
3 participants