Skip to content

RepositoryAnalysisFailureIT: disrupt earlier #127032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025
Merged

RepositoryAnalysisFailureIT: disrupt earlier #127032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2339da
RepositoryAnalysisFailureIT: disrupt earlier
bcully Apr 17, 2025
64e2ed4
Extract CountDown generator into static method
bcully Apr 17, 2025
dfd55e4
Use Dave's name
bcully Apr 17, 2025
6399c52
Merge branch 'main' of github.com:elastic/elasticsearch into 127029
bcully Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
RepositoryAnalysisFailureIT: disrupt earlier 
Fixes #127029

The fix to #126747 was only for one test. This applies
that change to all the tests in this suite that need it.
  • Loading branch information
@bcully
bcully committed Apr 17, 2025
commit d2339da521465dba3f28453518cccc923f94b066
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,9 +411,6 @@ tests:
- class: org.elasticsearch.packaging.test.DockerTests
method: test024InstallPluginFromArchiveUsingConfigFile
issue: https://github.com/elastic/elasticsearch/issues/126936
- class: org.elasticsearch.repositories.blobstore.testkit.analyze.RepositoryAnalysisFailureIT
method: testFailsOnReadError
issue: https://github.com/elastic/elasticsearch/issues/127029

# Examples:
#
Expand Down
6 changes: 3 additions & 3 deletions ...org/elasticsearch/repositories/blobstore/testkit/analyze/RepositoryAnalysisFailureIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void testFailsOnReadError() {
request.maxBlobSize(ByteSizeValue.ofBytes(10L));
request.abortWritePermitted(false);

final CountDown countDown = new CountDown(between(1, request.getBlobCount()));
final CountDown countDown = new CountDown(between(1, request.getBlobCount() / 2));
blobStore.setDisruption(new Disruption() {
@Override
public byte[] onRead(byte[] actualContents, long position, long length) throws IOException {
Expand All @@ -158,7 +158,7 @@ public void testFailsOnNotFoundAfterWrite() {
request.abortWritePermitted(false);
request.rareActionProbability(0.0); // not found on an early read or an overwrite is ok

final CountDown countDown = new CountDown(between(1, request.getBlobCount()));
final CountDown countDown = new CountDown(between(1, request.getBlobCount() / 2));

blobStore.setDisruption(new Disruption() {
@Override
Expand Down Expand Up @@ -212,7 +212,7 @@ public void testFailsOnChecksumMismatch() {
// leads to CI failures. Therefore, we disable rare actions to improve CI stability.
request.rareActionProbability(0.0);

final CountDown countDown = new CountDown(between(1, request.getBlobCount()));
final CountDown countDown = new CountDown(between(1, request.getBlobCount() / 2));

blobStore.setDisruption(new Disruption() {
@Override
Expand Down