[Profiling] Don't group by address if executable is known but function is unknown #129498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ignores the address or line number when grouping frames with unknown function name but known executable name.
Fully symbolized frames are not affected at all.
This change only affects how unsymbolized frames are grouped / aggregated.
For example, an unsymbolized
lib.so.6
sill appear as a single entry in the TopN functions view, and no longer as hundreds of different entries.In the flamegraph, this changed aggregation of frames leads to less complexity.
Here are screenshots that show the change as it is otherwise hard to phrase and understand.
Before

After
