Skip to content

[Profiling] Don't group by address if executable is known but function is unknown #129498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Profiling] Omit address in grouping for unknown function but known e…
…xecutable

This reduces the complexity of the flamegraph in unsymbolized areas.
Symbolized areas of the flamegraph are not affected.
  • Loading branch information
rockdaboot committed Jun 17, 2025
commit 589770edf9fc9d290b8a6068cbffe365968c97d2
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ public static String getBasenameAndParent(String fullPath) {

public static String create(String fileId, Integer addressOrLine, String exeFilename, String sourceFilename, String functionName) {
if (Strings.isEmpty(functionName)) {
return Integer.toString(Objects.hash(fileId, addressOrLine));
if (Strings.isEmpty(exeFilename)) {
return Integer.toString(Objects.hash(fileId, addressOrLine));
}
return Integer.toString(Objects.hash(exeFilename));
}
if (Strings.isEmpty(sourceFilename)) {
return Integer.toString(Objects.hash(fileId, functionName));
Expand Down