o365: fix handling of file size values and numeric IDs #14289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Integration:o365
efd6
force-pushed
the
o365-file_size_numbers
branch
from
72e6ab8 to
755443b
Compare
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
I ran this update on a test instance, and it looks like it fails if the My test cases. The first is currently failing, and the rest are passing. Prior to this change, the first two would pass and the last three failed. POST /_ingest/pipeline/logs-o365.audit-TEST/_simulate
{"docs":[
{"_source": {"o365audit": {"FileSizeBytes": 1249604}}},
{"_source": {"o365audit": {"FileSizeBytes": "1249604"}}},
{"_source": {"o365audit": {"FileSizeBytes": 1249604.0}}},
{"_source": {"o365audit": {"FileSizeBytes": "1249604.0"}}},
{"_source": {"o365audit": {"FileSizeBytes": "1.249604E6"}}}
]} |
mmahacek
reviewed
Jun 23, 2025
packages/o365/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
efd6
force-pushed
the
o365-file_size_numbers
branch
2 times, most recently
from
b8979dd to
f86de30
Compare
efd6
changed the title
O365 audit data may inclued decimal points and sizes may be represented with e-notation. These break the convert processor. To work around this, in the case of strings, non-digit characters were removed to allow parsing, but this was incorrect since it would add, e.g. significant zeros. Fix this all by using painless to conditionally convert/parse the values of the size field and render them in long.
efd6
force-pushed
the
o365-file_size_numbers
branch
from
f86de30 to
8461b69
Compare
💚 Build Succeeded
History
cc @efd6 |
|
chrisberkhout
approved these changes
Jun 30, 2025
|
Package o365 - 2.18.4 containing this change is available at https://epr.elastic.co/package/o365/2.18.4/ |
robester0403
pushed a commit
to robester0403/integrations
that referenced
this pull request
Jul 8, 2025
O365 audit file size data may include decimal points and sizes may be represented with e-notation. These break the convert processor. To work around this, in the case of strings, non-digit characters were removed to allow parsing, but this was incorrect since it would add, e.g. significant zeros. Fix this all by using painless to conditionally convert/parse the values of the size field and render them in long. It appears that Microsoft will sometimes send IDs as numeric values so be more careful when assessing for email-like IDs. Incidentally, also take more care when checking for port delimiters in IP values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots