Skip to content

o365: fix handling of file size values and numeric IDs #14289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

o365: fix handling of file size values and numeric IDs #14289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/o365/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# newer versions go on top
- version: "2.18.4"
changes:
- description: Fix handling of floating point encoded file sizes.
type: bugfix
link: https://github.com/elastic/integrations/pull/14289
- description: Fix handling of numeric IDs.
type: bugfix
link: https://github.com/elastic/integrations/pull/14289
- version: "2.18.3"
changes:
- description: Report failures in rename processor that occur when the organization.* fields are already present.
Expand Down
8 changes: 8 additions & 0 deletions packages/o365/data_stream/audit/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,21 @@ fields:
tags:
- preserve_original_event
numeric_keyword_fields:
- "event.id"
- "host.id"
- "o365.audit.ExceptionInfo.FalsePositive"
- "o365.audit.ExchangeMetaData.CC"
- "o365.audit.ExchangeMetaData.MessageID"
- "o365.audit.ExchangeMetaData.Sent"
- "o365.audit.ExchangeMetaData.To"
- "o365.audit.ExchangeMetaData.UniqueID"
- "o365.audit.FileSize"
- "o365.audit.Item.IsRecord"
- "o365.audit.Item.SizeInBytes"
- "o365.audit.OperationId"
- "o365.audit.RequestId"
- "o365.audit.SharePointMetaData.FileSize"
- "o365.audit.SharePointMetaData.IsViewableByExternalUsers"
- "o365.audit.UserId"
- "o365.audit.WorkspaceId"
- "organization.id"
163 changes: 163 additions & 0 deletions packages/o365/data_stream/audit/_dev/test/pipeline/test-numbery-json-events.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,163 @@
{
"events": [
{
"event": {
"original": "{\"Activity\":\"CreateArtifact\",\"WorkspaceName\":\"obszar_robaczy\",\"OrganizationId\":\"53d83e1d-xxx-xxx-84e9-01ec5045dd81\",\"Operation\":\"CreateArtifact\",\"Id\":\"a4420e70-b7a1-xxx-xxx-11e3364acd22\",\"CreationTime\":\"2024-01-30T14:23:40\",\"Timestamp\":\"2024-01-30T14:22:50\",\"UserId\":\"[email protected]\",\"ClientIP\":\"81.2.69.144\",\"RecordType\":20,\"ResultStatus\":\"InProgress\",\"ObjectDisplayName\":\"test_lakehouse\",\"OperationId\":\"a84f7f73-xxxx-xxxx-8cf3-094f69c23756\",\"Experience\":\"Lakehouse\",\"WorkspaceId\":\"91dad513-xxxx-xxxx-94bb-f5cbf305691c\",\"ObjectId\":\"0e00d1cf-825a-4d78-98ff-8a8199357669\",\"UserAgent\":\"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36\",\"Workload\":\"PowerBI\",\"RequestId\":\"fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b\",\"OperationProperties\":\"[{\\\"Name\\\":\\\"SystemArtifactType\\\",\\\"Value\\\":\\\"None\\\"}]\",\"ObjectType\":\"Lakehouse\",\"UserType\":0,\"UserKey\":\"xxxxxxxx\",\"FileSize\":1e9}"
},
"o365audit": {
"Activity": "CreateArtifact",
"WorkspaceName": "obszar_robaczy",
"OrganizationId": "53d83e1d-xxx-xxx-84e9-01ec5045dd81",
"Operation": "CreateArtifact",
"Id": "a4420e70-b7a1-xxx-xxx-11e3364acd22",
"CreationTime": "2024-01-30T14:23:40",
"Timestamp": "2024-01-30T14:22:50",
"UserId": "[email protected]",
"ClientIP": "81.2.69.144",
"RecordType": 20,
"ResultStatus": "InProgress",
"ObjectDisplayName": "test_lakehouse",
"OperationId": "a84f7f73-xxxx-xxxx-8cf3-094f69c23756",
"Experience": "Lakehouse",
"WorkspaceId": "91dad513-xxxx-xxxx-94bb-f5cbf305691c",
"ObjectId": "0e00d1cf-825a-4d78-98ff-8a8199357669",
"UserAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36",
"Workload": "PowerBI",
"RequestId": "fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b",
"OperationProperties": "[{\"Name\":\"SystemArtifactType\",\"Value\":\"None\"}]",
"ObjectType": "Lakehouse",
"UserType": 0,
"UserKey": "xxxxxxxx",
"FileSize": 1e9
}
},
{
"event": {
"original": "{\"AdditionalInfo\": \"{\\\"resourceDisplayName\\\":\\\"Track Pictures Viewer\\\"}\",\"Activity\":\"CreateArtifact\",\"WorkspaceName\":\"obszar_robaczy\",\"OrganizationId\":\"53d83e1d-xxx-xxx-84e9-01ec5045dd81\",\"Operation\":\"CreateArtifact\",\"Id\":\"a4420e70-b7a1-xxx-xxx-11e3364acd22\",\"CreationTime\":\"2024-01-30T14:23:40\",\"Timestamp\":\"2024-01-30T14:22:50\",\"UserId\":\"[email protected]\",\"ClientIP\":\"81.2.69.144\",\"RecordType\":20,\"ResultStatus\":\"InProgress\",\"ObjectDisplayName\":\"test_lakehouse\",\"OperationId\":\"a84f7f73-xxxx-xxxx-8cf3-094f69c23756\",\"Experience\":\"Lakehouse\",\"WorkspaceId\":\"91dad513-xxxx-xxxx-94bb-f5cbf305691c\",\"ObjectId\":\"0e00d1cf-825a-4d78-98ff-8a8199357669\",\"UserAgent\":\"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36\",\"Workload\":\"PowerBI\",\"RequestId\":\"fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b\",\"OperationProperties\":\"[]\",\"ObjectType\":\"Lakehouse\",\"UserType\":0,\"UserKey\":\"xxxxxxxx\",\"FileSize\":1000.0}"
},
"o365audit": {
"AdditionalInfo": "{\"resourceDisplayName\":\"Track Pictures Viewer\"}",
"Activity": "CreateArtifact",
"WorkspaceName": "obszar_robaczy",
"OrganizationId": "53d83e1d-xxx-xxx-84e9-01ec5045dd81",
"Operation": "CreateArtifact",
"Id": "a4420e70-b7a1-xxx-xxx-11e3364acd22",
"CreationTime": "2024-01-30T14:23:40",
"Timestamp": "2024-01-30T14:22:50",
"UserId": "[email protected]",
"ClientIP": "81.2.69.144",
"RecordType": 20,
"ResultStatus": "InProgress",
"ObjectDisplayName": "test_lakehouse",
"OperationId": "a84f7f73-xxxx-xxxx-8cf3-094f69c23756",
"Experience": "Lakehouse",
"WorkspaceId": "91dad513-xxxx-xxxx-94bb-f5cbf305691c",
"ObjectId": "0e00d1cf-825a-4d78-98ff-8a8199357669",
"UserAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36",
"Workload": "PowerBI",
"RequestId": "fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b",
"OperationProperties": "[]",
"ObjectType": "Lakehouse",
"UserType": 0,
"UserKey": "xxxxxxxx",
"FileSize": 1000.0
}
},
{
"event": {
"original": "{\"AdditionalInfo\": \"{\\\"resourceDisplayName\\\":\\\"Track Pictures Viewer\\\"}\",\"Activity\":\"CreateArtifact\",\"WorkspaceName\":\"obszar_robaczy\",\"OrganizationId\":\"53d83e1d-xxx-xxx-84e9-01ec5045dd81\",\"Operation\":\"CreateArtifact\",\"Id\":\"a4420e70-b7a1-xxx-xxx-11e3364acd22\",\"CreationTime\":\"2024-01-30T14:23:40\",\"Timestamp\":\"2024-01-30T14:22:50\",\"UserId\":\"[email protected]\",\"ClientIP\":\"81.2.69.144\",\"RecordType\":20,\"ResultStatus\":\"InProgress\",\"ObjectDisplayName\":\"test_lakehouse\",\"OperationId\":\"a84f7f73-xxxx-xxxx-8cf3-094f69c23756\",\"Experience\":\"Lakehouse\",\"WorkspaceId\":\"91dad513-xxxx-xxxx-94bb-f5cbf305691c\",\"ObjectId\":\"0e00d1cf-825a-4d78-98ff-8a8199357669\",\"UserAgent\":\"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36\",\"Workload\":\"PowerBI\",\"RequestId\":\"fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b\",\"OperationProperties\":\"[]\",\"ObjectType\":\"Lakehouse\",\"UserType\":0,\"UserKey\":\"xxxxxxxx\",\"FileSize\":\"1000.0\"}"
},
"o365audit": {
"AdditionalInfo": "{\"resourceDisplayName\":\"Track Pictures Viewer\"}",
"Activity": "CreateArtifact",
"WorkspaceName": "obszar_robaczy",
"OrganizationId": "53d83e1d-xxx-xxx-84e9-01ec5045dd81",
"Operation": "CreateArtifact",
"Id": "a4420e70-b7a1-xxx-xxx-11e3364acd22",
"CreationTime": "2024-01-30T14:23:40",
"Timestamp": "2024-01-30T14:22:50",
"UserId": "[email protected]",
"ClientIP": "81.2.69.144",
"RecordType": 20,
"ResultStatus": "InProgress",
"ObjectDisplayName": "test_lakehouse",
"OperationId": "a84f7f73-xxxx-xxxx-8cf3-094f69c23756",
"Experience": "Lakehouse",
"WorkspaceId": "91dad513-xxxx-xxxx-94bb-f5cbf305691c",
"ObjectId": "0e00d1cf-825a-4d78-98ff-8a8199357669",
"UserAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36",
"Workload": "PowerBI",
"RequestId": "fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b",
"OperationProperties": "[]",
"ObjectType": "Lakehouse",
"UserType": 0,
"UserKey": "xxxxxxxx",
"FileSize": "1000.0"
}
},
{
"event": {
"original": "{\"AdditionalInfo\": \"{\\\"resourceDisplayName\\\":\\\"Track Pictures Viewer\\\"}\",\"Activity\":\"CreateArtifact\",\"WorkspaceName\":\"obszar_robaczy\",\"OrganizationId\":\"53d83e1d-xxx-xxx-84e9-01ec5045dd81\",\"Operation\":\"CreateArtifact\",\"Id\":\"a4420e70-b7a1-xxx-xxx-11e3364acd22\",\"CreationTime\":\"2024-01-30T14:23:40\",\"Timestamp\":\"2024-01-30T14:22:50\",\"UserId\":\"[email protected]\",\"ClientIP\":\"81.2.69.144\",\"RecordType\":20,\"ResultStatus\":\"InProgress\",\"ObjectDisplayName\":\"test_lakehouse\",\"OperationId\":\"a84f7f73-xxxx-xxxx-8cf3-094f69c23756\",\"Experience\":\"Lakehouse\",\"WorkspaceId\":\"91dad513-xxxx-xxxx-94bb-f5cbf305691c\",\"ObjectId\":\"0e00d1cf-825a-4d78-98ff-8a8199357669\",\"UserAgent\":\"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36\",\"Workload\":\"PowerBI\",\"RequestId\":\"fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b\",\"OperationProperties\":\"[]\",\"ObjectType\":\"Lakehouse\",\"UserType\":0,\"UserKey\":\"xxxxxxxx\",\"FileSize\":\"1000.0\"}"
},
"o365audit": {
"AdditionalInfo": "{\"resourceDisplayName\":\"Track Pictures Viewer\"}",
"Activity": "CreateArtifact",
"WorkspaceName": "obszar_robaczy",
"OrganizationId": "53d83e1d-xxx-xxx-84e9-01ec5045dd81",
"Operation": "CreateArtifact",
"Id": "a4420e70-b7a1-xxx-xxx-11e3364acd22",
"CreationTime": "2024-01-30T14:23:40",
"Timestamp": "2024-01-30T14:22:50",
"UserId": "[email protected]",
"ClientIP": "81.2.69.144",
"RecordType": 20,
"ResultStatus": "InProgress",
"ObjectDisplayName": "test_lakehouse",
"OperationId": "a84f7f73-xxxx-xxxx-8cf3-094f69c23756",
"Experience": "Lakehouse",
"WorkspaceId": "91dad513-xxxx-xxxx-94bb-f5cbf305691c",
"ObjectId": "0e00d1cf-825a-4d78-98ff-8a8199357669",
"UserAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36",
"Workload": "PowerBI",
"RequestId": "fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b",
"OperationProperties": "[]",
"ObjectType": "Lakehouse",
"UserType": 0,
"UserKey": "xxxxxxxx",
"FileSize": 1000
}
},
{
"event": {
"original": "{\"AdditionalInfo\": \"{\\\"resourceDisplayName\\\":\\\"Track Pictures Viewer\\\"}\",\"Activity\":\"CreateArtifact\",\"WorkspaceName\":\"obszar_robaczy\",\"OrganizationId\":\"53d83e1d-xxx-xxx-84e9-01ec5045dd81\",\"Operation\":\"CreateArtifact\",\"Id\":\"a4420e70-b7a1-xxx-xxx-11e3364acd22\",\"CreationTime\":\"2024-01-30T14:23:40\",\"Timestamp\":\"2024-01-30T14:22:50\",\"UserId\":\"[email protected]\",\"ClientIP\":\"81.2.69.144\",\"RecordType\":20,\"ResultStatus\":\"InProgress\",\"ObjectDisplayName\":\"test_lakehouse\",\"OperationId\":\"a84f7f73-xxxx-xxxx-8cf3-094f69c23756\",\"Experience\":\"Lakehouse\",\"WorkspaceId\":\"91dad513-xxxx-xxxx-94bb-f5cbf305691c\",\"ObjectId\":\"0e00d1cf-825a-4d78-98ff-8a8199357669\",\"UserAgent\":\"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36\",\"Workload\":\"PowerBI\",\"RequestId\":\"fcbbe282-xxx-xxxx-xxxx-dc1e6d9b090b\",\"OperationProperties\":\"[]\",\"ObjectType\":\"Lakehouse\",\"UserType\":0,\"UserKey\":\"xxxxxxxx\",\"FileSize\":\"1000.0\"}"
},
"o365audit": {
"AdditionalInfo": "{\"resourceDisplayName\":\"Track Pictures Viewer\"}",
"Activity": "CreateArtifact",
"WorkspaceName": "obszar_robaczy",
"OrganizationId": 2,
"Operation": "CreateArtifact",
"Id": 6,
"CreationTime": "2024-01-30T14:23:40",
"Timestamp": "2024-01-30T14:22:50",
"UserId": 1,
"ClientIP": "81.2.69.144",
"RecordType": 20,
"ResultStatus": "InProgress",
"ObjectDisplayName": "test_lakehouse",
"OperationId": 4,
"Experience": "Lakehouse",
"WorkspaceId": 3,
"ObjectId": "0e00d1cf-825a-4d78-98ff-8a8199357669",
"UserAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36",
"Workload": "PowerBI",
"RequestId": 5,
"OperationProperties": "[]",
"ObjectType": "Lakehouse",
"UserType": 0,
"UserKey": "xxxxxxxx",
"FileSize": 1000
}
}
]
}
Loading