Syncing perfect-numbers exercise

exercises/practice/perfect-numbers/.meta/config.json

@@ -1,19 +1,13 @@
 {
-  "authors": [
-    "Average-user"
-  ],
-  "files": {
-    "solution": [
-      "perfect-numbers.lisp"
-    ],
-    "test": [
-      "perfect-numbers-test.lisp"
-    ],
-    "example": [
-      ".meta/example.lisp"
-    ]
-  },
-  "blurb": "Determine if a number is perfect, abundant, or deficient based on Nicomachus' (60 - 120 CE) classification scheme for positive integers.",
-  "source": "Taken from Chapter 2 of Functional Thinking by Neal Ford.",
-  "source_url": "https://www.oreilly.com/library/view/functional-thinking/9781449365509/"
+   "title": "Perfect Numbers",
+   "blurb": "Determine if a number is perfect, abundant, or deficient based on Nicomachus' (60 - 120 CE) classification scheme for positive integers.",
+   "source": "Taken from Chapter 2 of Functional Thinking by Neal Ford.",
+   "source_url": "https://www.oreilly.com/library/view/functional-thinking/9781449365509/",
+   "files": {
+      "test": ["perfect-numbers-test.lisp"],
+      "solution": ["perfect-numbers.lisp"],
+      "example": [".meta/example.lisp"]
+   },
+   "authors": ["Average-user"],
+   "contributors": []
 }

exercises/practice/perfect-numbers/.meta/example.lisp

@@ -4,14 +4,14 @@
 
 (in-package :perfect-numbers)
 
-(defun divisors (n)
-  (remove-if-not (lambda (x) (= 0 (rem n x)))
-                 (loop for x from 1 to (floor n 2) collect x)))
+(defun divisors (number)
+  (remove-if-not (lambda (x) (= 0 (rem number x)))
+                 (loop for x from 1 to (floor number 2) collect x)))
 
-(defun classify (n)
-  (if (> n 0)
-    (let ((div-sum (reduce #'+ (divisors n))))
-      (cond ((= n div-sum) "perfect")
-            ((< n div-sum) "abundant")
-            (T             "deficient")))
-    (warn "Just defined for natural numbers")))
+(defun classify (number)
+  (if (> number 0)
+      (let ((div-sum (reduce #'+ (divisors number))))
+        (cond ((= number div-sum) "perfect")
+              ((< number div-sum) "abundant")
+              (T             "deficient")))
+      (warn "Just defined for natural numbers")))

exercises/practice/perfect-numbers/.meta/tests.toml

@@ -36,7 +36,7 @@ description = "Large deficient number is classified correctly"
 description = "Edge case (no factors other than itself) is classified correctly"
 
 [72445cee-660c-4d75-8506-6c40089dc302]
-description = "Zero is rejected (not a natural number)"
+description = "Zero is rejected (as it is not a positive integer)"
 
 [2d72ce2c-6802-49ac-8ece-c790ba3dae13]
-description = "Negative integer is rejected (not a natural number)"
+description = "Negative integer is rejected (as it is not a positive integer)"

exercises/practice/perfect-numbers/perfect-numbers-test.lisp

@@ -15,39 +15,57 @@
 ;; Define and enter a new FiveAM test-suite
 (def-suite* perfect-numbers-suite)
 
-(test smallest-perfect-number
- (is (equal "perfect" (perfect-numbers:classify 6))))
+(test smallest-perfect-number-is-classified-correctly
+    (let ((number 6))
+      (is (string= "perfect" (perfect-numbers:classify number)))))
 
-(test medium-perfect-number
- (is (equal "perfect" (perfect-numbers:classify 28))))
+(test medium-perfect-number-is-classified-correctly
+    (let ((number 28))
+      (is (string= "perfect" (perfect-numbers:classify number)))))
 
-(test large-perfect-number
- (is (equal "perfect" (perfect-numbers:classify 33550336))))
+(test large-perfect-number-is-classified-correctly
+    (let ((number 33550336))
+      (is (string= "perfect" (perfect-numbers:classify number)))))
 
-(test smallest-abundant-number
- (is (equal "abundant" (perfect-numbers:classify 12))))
+(test smallest-abundant-number-is-classified-correctly
+    (let ((number 12))
+      (is (string= "abundant" (perfect-numbers:classify number)))))
 
-(test medium-abundant-number
- (is (equal "abundant" (perfect-numbers:classify 30))))
+(test medium-abundant-number-is-classified-correctly
+    (let ((number 30))
+      (is (string= "abundant" (perfect-numbers:classify number)))))
 
-(test large-abundant-number
- (is (equal "abundant" (perfect-numbers:classify 33550335))))
+(test large-abundant-number-is-classified-correctly
+    (let ((number 33550335))
+      (is (string= "abundant" (perfect-numbers:classify number)))))
 
-(test smallest-prime-deficient-number
- (is (equal "deficient" (perfect-numbers:classify 2))))
+(test smallest-prime-deficient-number-is-classified-correctly
+    (let ((number 2))
+      (is (string= "deficient" (perfect-numbers:classify number)))))
 
-(test smallest-non-prime-deficient-number
- (is (equal "deficient" (perfect-numbers:classify 1))))
+(test smallest-non-prime-deficient-number-is-classified-correctly
+    (let ((number 4))
+      (is (string= "deficient" (perfect-numbers:classify number)))))
 
-(test medium-deficient-number
- (is (equal "deficient" (perfect-numbers:classify 32))))
+(test medium-deficient-number-is-classified-correctly
+    (let ((number 32))
+      (is (string= "deficient" (perfect-numbers:classify number)))))
 
-(test large-deficient-number
- (is (equal "deficient" (perfect-numbers:classify 33550337))))
+(test large-deficient-number-is-classified-correctly
+    (let ((number 33550337))
+      (is (string= "deficient" (perfect-numbers:classify number)))))
 
-(test undefinded-0 (is (equal nil (perfect-numbers:classify 0))))
+(test edge-case-no-factors-other-than-itself-is-classified-correctly
+    (let ((number 1))
+      (is (string= "deficient" (perfect-numbers:classify number)))))
 
-(test undefined-negative (is (equal nil (perfect-numbers:classify -3))))
+(test zero-is-rejected-as-it-is-not-a-positive-integer
+    (let ((number 0))
+      (is (equal NIL (perfect-numbers:classify number)))))
+
+(test negative-integer-is-rejected-as-it-is-not-a-positive-integer
+    (let ((number -1))
+      (is (equal NIL (perfect-numbers:classify number)))))
 
 (defun run-tests (&optional (test-or-suite 'perfect-numbers-suite))
   "Provides human readable results of test run. Default to entire suite."

exercises/practice/perfect-numbers/perfect-numbers.lisp

@@ -4,4 +4,4 @@
 
 (in-package :perfect-numbers)
 
-(defun classify (n))
+(defun classify (number))