Skip to content

✨ ADR: action pinning #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

✨ ADR: action pinning #366

wants to merge 2 commits into from

Conversation

ctcpip
Copy link
Member

@ctcpip ctcpip commented Apr 30, 2025

No description provided.

@ctcpip ctcpip requested a review from a team April 30, 2025 16:06
@ctcpip ctcpip added top priority Issues which the TC deem our current highest priorities for the project tc agenda labels Apr 30, 2025
@Phillip9587
Copy link

Should we note that if a repository opts to pin actions by commit SHA, it's recommended to set up Dependabot (or a similar tool) to regularly update these SHAs?

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

1396308b-0814-47bd-b8fc-6b3965d31295

🤣 We moving to a content addressable sha for the ADR numbers? I approve!

@ctcpip
Copy link
Member Author

ctcpip commented Apr 30, 2025

LGTM!

1396308b-0814-47bd-b8fc-6b3965d31295

🤣 We moving to a content addressable sha for the ADR numbers? I approve!

you put #306 on the perf one, so I was like... 🤷

@wesleytodd
Copy link
Member

wesleytodd commented Apr 30, 2025

Ha, that was the number from the PR. Dont get me wrong, I like the creativity, we gotta keep people guessing.

EDIT: oops, looks like I forgot to update this one

EDIT 2: ok I went a bit overboard: #367

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tc agenda top priority Issues which the TC deem our current highest priorities for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants