Skip to content

fix: ADR cleanup #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ADR cleanup #367

wants to merge 1 commit into from

Conversation

wesleytodd
Copy link
Member

No description provided.

@wesleytodd wesleytodd requested a review from ctcpip April 30, 2025 22:27
@ctcpip
Copy link
Member

ctcpip commented Apr 30, 2025

hmmm... hate to say it but I think we need an ADR for numbering... UUID? monotonically increasing integer starting from 1? PR number? 🤔🤔🤔🤔🤔🤔🤔🤔🤔

@wesleytodd
Copy link
Member Author

I was just kidding because of our exchange, but I really do think PR number is a reasonable way. No need to go look it up when merging (and forget, like I did). At least these numbers mean something.

@ctcpip
Copy link
Member

ctcpip commented May 1, 2025

slight dispreference due to not knowing in advance what the PR number will be. (or guessing and risking race condition), meaning a follow-on commit will always be required

also not convinced we need numeric/symbolic identifiers at all, but I have little appetite to bikeshed this

@wesleytodd
Copy link
Member Author

also not convinced we need numeric/symbolic identifiers at all, but I have little appetite to bikeshed this

Ok, you have me sold on this. I almost did this in the PR but realized that it meant the file names might become more important.

Honestly I just did this as a joke, we can even close it if we just want to let the lord of chaos reign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants