Support Scribble Handwriting #24224

fbcouch · 2021-02-05T02:44:52Z

This PR is the engine side of adding scribble handwriting support. I still need to clean up the NSLogs and add some tests, but looking for feedback on the overall approach. I did incorporate some feedback from @LongCatIsLooong on a previous draft, moving most of the logic of this into the framework and adding a widget there to handle most of the scribble-specific logic.

flutter/flutter#61278

Design doc: https://docs.google.com/document/d/1mjQbsSRQnHuAgMNdouaSgTS-Xv-w57fdKfOUUafWpRo

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.
The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

[scribble] Implement some more methods [scribble] Clean up some things, add some logging and forward touch event selectors to superview to try to fix this issue where the cursor cant be moved easily [scribble] Use UIScribbleInteractionDelegate to disable setMarkedText during scribble; add a reference to the viewController to send touch events to [scribble] Do not send showAutocorrectionPromptRectForStart from firstRectForRange while scribble is in progress - that's what was causing the last character to always be selected [scribble] Send 'showToolbar' message over the text input channel and add scribbleInProgress key to the editing state [scribble] Add UIIndirectScribbleInteraction and Delegate [scribble] Focuses, but not smoothly [scribble] Able to focus in 'correct' position [scribble] Track scribble rects on the framework side [scribble] Clean up before rebase

…rom TextInputState, update separately

…ods so that the withinRange version is called by the other

…oveTextPlaceholder to the framework

…ters like emoji

…e FlutterTextInputViewAccessibilityHider from views, as it prevents direct scribble interactions

…er so text doesn't flyaway to the end of the string for some reason

…; support focusing immediately

…now...not sure how that's the case, but OK; also fix some things so that the weird issue with zero width joiner characters seems to be fixed now as well

chinmaygarde · 2021-05-13T21:49:46Z

@chunhtai This seems ready for review. Are you able to take a look please?

chunhtai · 2021-05-15T00:04:52Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

@@ -289,6 +289,8 @@ - (void)setViewController:(FlutterViewController*)viewController {

 - (void)attachView {
  self.iosPlatformView->attachView();
+  _textInputPlugin.get().viewController = [self viewController];


what if the view controller changes during the lifetime of the flutterengine?
also flutter holdsa weak ptr to the viewcontroller, I am not sure what will happen to the assign property of _textInputPlugin if the pointer is nulled in flutterengine, cc @gaaclarke

@chunhtai I also set this property below on like 476, I'm not sure whether or not that would fix the issue – how would I test that? I don't know when the view controller would change

I think the viewcontroller of the textinputplugin need to be set in FlutterEngine.setViewController, and it also need to nil it in FlutterEngine.notifyViewControllerDeallocated. To test this, you can swap out view controller when you run the FlutterEngine and see if things still work

@chunhtai I may need some more guidance on how to test this...I tried the following, but the notifyViewControllerDeallocated method doesn't seem to get hit when swapping out the view controller – attachView does get called again, so I think it is "working":

@UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { override func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? ) -> Bool { var controller = window.rootViewController as! FlutterViewController let criticChannel = FlutterMethodChannel(name: "test.viewController", binaryMessenger: controller as! FlutterBinaryMessenger) criticChannel.setMethodCallHandler { (call: FlutterMethodCall, result: @escaping FlutterResult) -> Void in if call.method == "swap" { let engine = controller.engine! engine.viewController = nil self.window.rootViewController = FlutterViewController(engine: engine, nibName: controller.nibName, bundle: controller.nibBundle) controller = self.window.rootViewController as! FlutterViewController result(nil) } else { result(FlutterMethodNotImplemented) } } GeneratedPluginRegistrant.register(with: self) return super.application(application, didFinishLaunchingWithOptions: launchOptions) } }

@chunhtai I updated the setupIndirectScribbleInteraction method to take in the FlutterViewController instead of setting it directly in the engine, that way we're setting up that interaction every time the view controller changes. I also added a resetViewController method to nil the viewController from that notifyViewControllerDeallocated method, though I still haven't managed to actually have that get hit 🤷‍♂️

you will need to hold a strong reference FlutterViewController somewhere and pass that into the flutter engine. and then nil the strong reference, this should cause garbage collection to dealloc the FlutterViewController, which will then call the notifyViewControllerDeallocated.

can you write a unit test for this? so that we don't break this unintentionally.

chunhtai · 2021-05-15T00:08:32Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

+}
+
+- (void)scribbleInteractionBegan {
+  [_textInputChannel.get() invokeMethod:@"TextInputClient.scribbleInteractionBegan" arguments:nil];


should there be a framework pr associated with the change? it may be easier to review if you can also create the framework part pr

@chunhtai Yes, I should have put a link to it in the description. Here it is: flutter/flutter#75472

…tPlugin to nil and set _hasScribbleInteraction to false when the view controller becomes nil

…leInteraction method and set up the interaction every time the viewController changes

gaaclarke

I gave this a quick glance, seems promising thanks. In its current state there is still a fair bit of slapdash memory management. You're going to have to clean that up before merging.

gaaclarke · 2021-05-27T21:24:00Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

@@ -471,6 +473,7 @@ - (void)setupChannels {

  _textInputPlugin.reset([[FlutterTextInputPlugin alloc] init]);
  _textInputPlugin.get().textInputDelegate = self;
+  [_textInputPlugin.get() setupIndirectScribbleInteraction:[self viewController]];


s/[self viewController]/self.viewController; here and everywhere else.

gaaclarke · 2021-05-27T21:27:02Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputDelegate.h

+- (void)focusElement:(UIScribbleElementIdentifier)elementIdentifier
+             atPoint:(CGPoint)referencePoint
+              result:(id)callback;
+- (void)requestElementsInRect:(CGRect)rect result:(id)callback;


Why is this parameter id? Please specify a specific type.

gaaclarke · 2021-05-27T21:32:28Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+
+#pragma mark - Methods related to Scribble support
+
+- (void)setupIndirectScribbleInteraction:(FlutterViewController*)viewController {


There already is a public setter for this via the property setViewController. If people are expected to use this instead considering putting this logic in that method or making the property readonly.

gaaclarke · 2021-05-27T21:33:57Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

@@ -505,6 +557,9 @@ @implementation FlutterTextInputView {
  const char* _selectionAffinity;
  FlutterTextRange* _selectedTextRange;
  CGRect _cachedFirstRect;
+  NSArray* _selectionRects;


Use property instead of ivar so the memory management is explicit. I don't see a release for this array so it's probably leaking.

gaaclarke · 2021-05-27T21:35:44Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+      [NSNumber numberWithFloat:[rect[3] floatValue]], [NSNumber numberWithInt:[rect[4] intValue]]
+    ]];
+  }
+  _selectionRects = rectsAsRect;


This is leaking, making it a property as I mentioned above will help you fix that.

You need to actually used this as a property to get the memory management benefits self.selectionRects = rectsAsRect;

So, the issue is that this is the setter for that property – so if I reference it as self.selectionRects, I get an error about _selectionRects not being referenced:

../../flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm:1182:1: error: ivar '_selectionRects' which backs the property is not referenced in this property's accessor [-Werror,-Wunused-property-ivar]``` So, it looks to me like `setSelectedTextRangeLocal` does a similar thing where it sets `_selectedTextRange` directly, so I'm not sure what the right thing to do is here – perhaps I just need to rename this method to not override the setter?

Would adding autorelease to the rectsAsRect declaration help?

gaaclarke · 2021-05-27T21:43:45Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+          CGPointMake(rect.origin.x + rect.size.width, rect.origin.y + rect.size.height * 0.5);
+      float yDist = abs(pointForComparison.y - point.y);
+      float xDist = abs(pointForComparison.x - point.x);
+      if (yDist < _closestY - 1 ||


Looks like duplicated logic from above, more reason to make it a static function.

gaaclarke · 2021-05-27T21:45:58Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+- (UITextPlaceholder*)insertTextPlaceholderWithSize:(CGSize)size {
+  [_textInputDelegate insertTextPlaceholderWithSize:size withClient:_textInputClient];
+  _hasPlaceholder = YES;
+  return [[FlutterTextPlaceholder alloc] init];


You shouldn't return values that aren't released by the autorelease pool (read as this PR won't be accepted unless that change is made).

gaaclarke · 2021-05-27T21:46:18Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

@@ -1270,9 +1549,11 @@ @interface FlutterTextInputPlugin ()

 @implementation FlutterTextInputPlugin {
  NSTimer* _enableFlutterTextInputViewAccessibilityTimer;
+  NSMutableDictionary<UIScribbleElementIdentifier, NSValue*>* _scribbleElements;


use a property so the memory management is explicit

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

gaaclarke · 2021-05-27T21:47:33Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+  // TODO(fbcouch): only do this on iPadOS?
+  // This is necessary to set up where the scribble interactable element will be
+  _activeView.frame =
+      CGRectMake([dictionary[@"transform"][12] intValue], [dictionary[@"transform"][13] intValue],


12 and 13 should be annotated variables.

chinmaygarde · 2021-06-03T21:58:41Z

@fbcouch Any updates based on the Aarons review?

fbcouch · 2021-06-03T22:17:19Z

@chinmaygarde I am hoping to address the new comments either tomorrow or early next week (thanks @gaaclarke for the feedback – I will readily admit I don't really know what I'm doing with memory management in objc, but I'll try to make the adjustments requested)

fbcouch · 2021-10-25T18:29:54Z

@gaaclarke @justinmc Yes, that's correct, that example should work just fine.

gaaclarke · 2021-10-29T18:12:08Z

Okay so I tested it locally. It mostly works. Drawing a line through text to select it works, but the highlight of the region isn't rendered:

If I background the app, then bring it back, the text is selected correctly.

gaaclarke · 2021-10-29T20:12:40Z

Hey @justinmc since this mostly works, do you think we can land this behind a flag? So @fbcouch doesn't have to maintain these 2 big PR's? Then they could just land little patches to fix things up and when we are happy with it we can remove the flag?

gaaclarke · 2021-10-29T20:18:16Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

@@ -397,6 +397,65 @@ static FlutterAutofillType autofillTypeOf(NSDictionary* configuration) {
  return FlutterAutofillTypeNone;
 }

+static BOOL isApproximatelyEqual(float x, float y, float delta) {
+  return x >= y - delta && x <= y + delta;


fyi: fabsf(x - y) <= delta is less operations (3-5 versus 3)

gaaclarke · 2021-10-29T20:22:29Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+static BOOL isScribbleAvailable() {
+  if (@available(iOS 14.0, *)) {
+    NSString* deviceModel = (NSString*)[UIDevice currentDevice].model;
+    if ([[deviceModel substringWithRange:NSMakeRange(0, 4)] isEqualToString:@"iPad"]) {


if ( UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad ) is another way

gaaclarke · 2021-10-29T20:26:14Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

@@ -625,14 +753,11 @@ - (instancetype)init {
      _smartQuotesType = UITextSmartQuotesTypeYes;
      _smartDashesType = UITextSmartDashesTypeYes;
    }
+    _selectionRects = @[];


This is a potential crash, it should be _selectionRects = [@[] retain]; or _selectionRects = [[NSArray alloc] init]. The literal is on the autorelease pool and can be deleted before you access it.

gaaclarke · 2021-10-29T20:28:25Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+       action == @selector(delete:) || action == @selector(makeTextWritingDirectionLeftToRight:) ||
+       action == @selector(makeTextWritingDirectionRightToLeft:) ||
+       action == @selector(toggleBoldface:) || action == @selector(toggleItalics:) ||
+       action == @selector(toggleUnderline:) || action == NSSelectorFromString(@"_define:") ||


_define: is a private selector? This may get flagged by iOS app review.

That's a good point...we might have to make a whitelist instead of a blacklist to get around that...I'll look into that.

Actually, I think we can just return NO for everything – I think the big thing I was worried about was saying no to the accessibility ones, but I just tried it with VoiceOver and it seems to still be able to navigate/read the TextInput.

gaaclarke · 2021-10-29T20:33:27Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+
+  _scribbleFocusStatus = FlutterScribbleFocusStatusUnfocused;
+  [self resetScribbleInteractionStatusIfEnding];
+  _selectionRects = copiedRects;


This is leaking the old value of _selectionRects, use self.selectionRects = copiedRects; [copiedRects release];

justinmc · 2021-10-29T21:52:09Z

I'm on board with merging this behind a flag 👍

fbcouch · 2021-11-05T15:16:00Z

@gaaclarke Thanks for the review and testing it out. This is interesting, because it seems that a MaterialTextField works correctly, but CupertinoTextField doesn't. I'll dig into that, but do you or @justinmc know off the top of your head if there's some difference in how they display that highlight?

I like the idea of landing behind a flag – how difficult will that be to enable in an app? (We're currently frozen on flutter 1.22.6 to avoid having to make multiple custom engine versions)

fbcouch · 2021-11-05T16:02:51Z

So the issue with the CupertinoTextField appears to be that focusing with the pencil doesn't trigger the _handleFocusChanged callback, so the widget doesn't get rebuilt knowing that it has focus. I'll see if I can figure out a quick fix for that.

fbcouch · 2021-11-05T16:59:05Z

Yep, it wasn't adding the focus listener in initState like the Material version does (flutter/flutter@f309302). So, @gaaclarke could you test again? Thanks!

gaaclarke

I tested it out and it works for me. I looked through the code and it looks good now. I don't see any obvious errors. Thanks Jami, awesome job!

gaaclarke · 2021-11-05T17:42:01Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+    if (@available(iOS 14.0, *)) {
+      UIView* parentView = viewResponder.view;
+      if (parentView != nil) {
+        UIIndirectScribbleInteraction* _scribbleInteraction =


s/_scribbleInteraction/scribbleInteraction

fbcouch · 2021-11-08T20:35:15Z

@gaaclarke Awesome, thanks for all your time giving feedback on this!

morio77 · 2021-12-29T09:21:26Z

@fbcouch

I am using the flutter master channel.

Is it a bug that when I draw with Apple Pencil with scribble turned on in iPad settings, scribble trails are displayed in most widgets including AppBar widget?

Also, is this related to this PR?

By the way, the problem does not occur in flutter 2.0.0 to 2.8.1, only in the master channel.

fbcouch · 2021-12-29T20:06:09Z

@morio77 I think that is an issue that will be resolved once the framework PR is merged (see flutter/flutter#75472 ). If you use that branch instead, things should work properly. I think the issue is that the TextInputClient.focusElement method invocation is not being responded to properly by the framework, so the completion method is not getting called in a timely manner in the - focusElementIfNeeded method

cyanglaz · 2022-07-13T17:33:12Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

@@ -331,6 +334,7 @@ - (void)setViewController:(FlutterViewController*)viewController {

 - (void)attachView {
  self.iosPlatformView->attachView();
+  [_textInputPlugin.get() setupIndirectScribbleInteraction:self.viewController];


Came across this while looking into refactoring attachView. Does it make sense to move this line somewhere else? setupIndirectScribbleInteraction:self doesn't sound like should be a part of "attachView"

Maybe there's a better place for it...iirc it's purpose here is to make sure the indirect scribble interaction is set up along with the view – that is something that needs to always be there so that we can capture scribble interactions that happen outside of text areas

flutter-dashboard bot added the platform-ios label Feb 5, 2021

googlebot added the cla: yes label Feb 5, 2021

fbcouch changed the title ~~Support Scribble Handrwriting~~ Support Scribble Handwriting Feb 5, 2021

fbcouch force-pushed the feature/scribble+master branch from 7f5494d to 700fcd9 Compare April 8, 2021 20:26

fbcouch commented Apr 8, 2021

View reviewed changes

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm Outdated Show resolved Hide resolved

fbcouch added 13 commits May 5, 2021 16:38

[scribble+master] Addressing PR feedback: remove scribbleInProgress f…

9104fe5

…rom TextInputState, update separately

[scribble+master] Improve closestPositionToPoint algorithm

abbdbf9

[scribble+master] Add tests, refactor the closestPositionToPoint meth…

92268b9

…ods so that the withinRange version is called by the other

[scribble+master] Run clang-format

2af5fe9

[scribble+master] Pass calls to insertTextPlaceholderWithSize and rem…

0844910

…oveTextPlaceholder to the framework

[scribble+master] Update scribble support to handle multi-byte charac…

3e87027

…ters like emoji

[scribble+master-updated] Clean up some misses during rebasing, remov…

d230e1b

…e FlutterTextInputViewAccessibilityHider from views, as it prevents direct scribble interactions

[scribble+master-updated] Fixup my tests

6035793

[scribble+master] Clear selection rects on insert text with placehold…

9105c21

…er so text doesn't flyaway to the end of the string for some reason

[scribble+master] Add placeholder selection rects when inserting text…

487bab4

…; support focusing immediately

[scribble+master] Add back autofill hider stuff, which seems to work …

7c784c3

…now...not sure how that's the case, but OK; also fix some things so that the weird issue with zero width joiner characters seems to be fixed now as well

[scribble+master] Add Twin Sun, LLC to AUTHORS

b57c05a

fbcouch force-pushed the feature/scribble+master branch from 65d40ac to b57c05a Compare May 5, 2021 21:40

[scribble+master] Remove NSLogs and some TODOs

ed6d050

fbcouch marked this pull request as ready for review May 6, 2021 01:27

chunhtai reviewed May 15, 2021

View reviewed changes

fbcouch mentioned this pull request May 17, 2021

Support Scribble Handwriting flutter/flutter#75472

Merged

8 tasks

fbcouch added 2 commits May 20, 2021 17:07

[scribble+master] Add 'resetViewController' method to FlutterTextInpu…

5746e60

…tPlugin to nil and set _hasScribbleInteraction to false when the view controller becomes nil

[scribble+master] Pass FlutterViewController into setupIndirectScribb…

97c67b4

…leInteraction method and set up the interaction every time the viewController changes

gaaclarke suggested changes May 27, 2021

View reviewed changes

chinmaygarde added the waiting for customer response label Jun 3, 2021

Merge branch 'master' into feature/scribble+master

99de581

gaaclarke reviewed Oct 29, 2021

View reviewed changes

Incorporate feedback

07e195c

Merge branch 'master' into feature/scribble+master

975177b

fbcouch requested a review from gaaclarke November 5, 2021 17:00

gaaclarke approved these changes Nov 5, 2021

View reviewed changes

Rename scribbleInteraction variable

ee11699

gaaclarke merged commit 1ae721c into flutter:master Nov 8, 2021

engine-flutter-autoroll mentioned this pull request Nov 8, 2021

Roll Engine from 469d6f1a09f4 to 1ae721c0230e (11 revisions) flutter/flutter#93284

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2021

1ae721c Support Scribble Handwriting (flutter/engine#24224)

29dc63a

gaaclarke mentioned this pull request Nov 29, 2021

Support for Apple Pencil angle, pressure, and other sensor input on iPad flutter/flutter#38135

Closed

justinmc mentioned this pull request Feb 2, 2022

Re-land "Support Scribble Handwriting" (#96615) flutter/flutter#97437

Merged

8 tasks

cyanglaz mentioned this pull request Feb 25, 2022

[iOS][iPad]: Textfield not responding to CMD+C and CMD+V shortcuts using external keyboard flutter/flutter#98832

Closed

justinmc mentioned this pull request Feb 26, 2022

Fix copy/paste when scribble enabled #31691

Merged

fbcouch mentioned this pull request Mar 31, 2022

Provide default method call handler for SystemChannels.textInput flutter/flutter#101087

Merged

8 tasks

jmagman mentioned this pull request May 6, 2022

[iPadOS] Keyboard shortcut actions are disabled flutter/flutter#102940

Closed

cyanglaz reviewed Jul 13, 2022

View reviewed changes

justinmc mentioned this pull request Sep 16, 2022

TextField to support samsung spen handwritting input flutter/flutter#111003

Open

justinmc mentioned this pull request Nov 17, 2022

Support stylus handwriting input on Android flutter/flutter#115607

Closed

justinmc mentioned this pull request Jul 21, 2023

Can't delete and separate words by Scribble with Apple Pencil written on TextFormField when setting maxLines 1 flutter/flutter#121868

Open


		#pragma mark - Methods related to Scribble support

		- (void)setupIndirectScribbleInteraction:(FlutterViewController*)viewController {

Support Scribble Handwriting #24224

Support Scribble Handwriting #24224

Conversation

fbcouch commented Feb 5, 2021 • edited Loading

Pre-launch Checklist

chinmaygarde commented May 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbcouch May 15, 2021 • edited Loading

Choose a reason for hiding this comment

gaaclarke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chinmaygarde commented Jun 3, 2021

fbcouch commented Jun 3, 2021

fbcouch commented Oct 25, 2021

gaaclarke commented Oct 29, 2021

gaaclarke commented Oct 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinmc commented Oct 29, 2021

fbcouch commented Nov 5, 2021

fbcouch commented Nov 5, 2021

fbcouch commented Nov 5, 2021

gaaclarke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbcouch commented Nov 8, 2021

morio77 commented Dec 29, 2021

fbcouch commented Dec 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbcouch commented Feb 5, 2021 •

edited

Loading

fbcouch May 15, 2021 •

edited

Loading