Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Support Scribble Handwriting #24224

Merged
merged 63 commits into from
Nov 8, 2021
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
8278027
[scribble+master] [scribble] Very rough proof of concept
fbcouch Dec 16, 2020
9104fe5
[scribble+master] Addressing PR feedback: remove scribbleInProgress f…
fbcouch Feb 9, 2021
abbdbf9
[scribble+master] Improve closestPositionToPoint algorithm
fbcouch Feb 24, 2021
92268b9
[scribble+master] Add tests, refactor the closestPositionToPoint meth…
fbcouch Feb 25, 2021
2af5fe9
[scribble+master] Run clang-format
fbcouch Feb 26, 2021
0844910
[scribble+master] Pass calls to insertTextPlaceholderWithSize and rem…
fbcouch Mar 5, 2021
3e87027
[scribble+master] Update scribble support to handle multi-byte charac…
fbcouch Apr 6, 2021
d230e1b
[scribble+master-updated] Clean up some misses during rebasing, remov…
fbcouch Apr 8, 2021
6035793
[scribble+master-updated] Fixup my tests
fbcouch Apr 8, 2021
9105c21
[scribble+master] Clear selection rects on insert text with placehold…
fbcouch Apr 21, 2021
487bab4
[scribble+master] Add placeholder selection rects when inserting text…
fbcouch Apr 30, 2021
7c784c3
[scribble+master] Add back autofill hider stuff, which seems to work …
fbcouch Apr 30, 2021
b57c05a
[scribble+master] Add Twin Sun, LLC to AUTHORS
fbcouch Apr 30, 2021
ed6d050
[scribble+master] Remove NSLogs and some TODOs
fbcouch May 6, 2021
5746e60
[scribble+master] Add 'resetViewController' method to FlutterTextInpu…
fbcouch May 20, 2021
97c67b4
[scribble+master] Pass FlutterViewController into setupIndirectScribb…
fbcouch May 21, 2021
deb3ae9
[scribble+master] Address PR feedback – memory management, extract co…
fbcouch Jun 4, 2021
9d2e501
[scribble+master] Remove FlutterViewController import, remove unneces…
fbcouch Jul 1, 2021
67d471a
[scribble+master] Use dynamic instead of synthesize for inherited pro…
fbcouch Jul 1, 2021
d10c767
[scribble+master] Remove some useless copy calls, extract logic of fi…
fbcouch Jul 1, 2021
561935f
[scribble+master] Adding some (I think) missing autoreleases and clea…
fbcouch Jul 1, 2021
4be3dd2
[scribble+master] Remove a couple more unnecessary synthesize calls, …
fbcouch Jul 1, 2021
25f4100
[scribble+master] Swap back to synthesize for FlutterTextSelectionRec…
fbcouch Jul 1, 2021
34db3dd
[scribble+master] Genericize selectionRects NSArray
fbcouch Jul 1, 2021
f6adcd9
[scribble+master] Merge branch 'master' into feature/scribble+master
fbcouch Jul 1, 2021
82f9ce6
[scribble+master] Fix formatting issues and swap from _reusableInputV…
fbcouch Jul 1, 2021
85f8665
Couple more memory things
fbcouch Jul 1, 2021
ea37dfa
Clear scribbleFocused flag in touchesBegan, insert/delete text rather…
fbcouch Jul 2, 2021
671f29c
did a bit of cleanup (the easy stuff)
gaaclarke Jul 3, 2021
6eed8a7
extract FlutterIndirectScribbleDelegate interface to handle requestEl…
fbcouch Jul 13, 2021
39a3579
Merge branch 'master' into feature/scribble+master
fbcouch Jul 20, 2021
6ac1cb6
Update new member of FlutterTextInputDelegate to pass caller as first…
fbcouch Jul 20, 2021
b123246
Refactor out FlutterViewResponder protocol, swap focused/focusing boo…
fbcouch Jul 20, 2021
46bacea
Add position member to FlutterTextSelectionRect and use that to repre…
fbcouch Jul 20, 2021
a622e83
Fix linter errors
fbcouch Jul 20, 2021
640267e
Fix tests to use new selection rects and delegate style
fbcouch Jul 22, 2021
f2d67b5
Add some more tests for scribble functions
fbcouch Jul 26, 2021
7bfe2e9
Add new headers to licenses_flutter golden file
fbcouch Jul 26, 2021
8fae879
Rename viewController to viewResponder; move viewResponder prop on th…
fbcouch Jul 26, 2021
4008ea4
More PR changes; provide frame to inputHider so that UIScribbleIntera…
fbcouch Aug 4, 2021
c6aa05e
Swap scribbleInProgress over to enum, fix issue where cursor wouldn't…
fbcouch Aug 4, 2021
a39f759
Fix up tests, remove logs, prevent native toolbar from popping up
fbcouch Aug 4, 2021
7a4e440
Add back errant removal of setSelectedTextRangeLocal call in replaceR…
fbcouch Aug 7, 2021
3ec718b
Merge branch 'master' into feature/scribble+master
fbcouch Aug 9, 2021
a95f2d9
Add workarounds for UITextInteraction-related selection and gesture p…
fbcouch Aug 9, 2021
c0aeba0
Change up workaround a bit to move add the UITextInteraction in -begi…
fbcouch Aug 11, 2021
ae8f536
Move setup of UIScribbleInteraction to the init method of FlutterText…
fbcouch Aug 11, 2021
f106b91
Remove remaining NSLog
fbcouch Aug 12, 2021
a141a14
Add guard clause to selectionRectsForRange to prevent crash when chan…
fbcouch Aug 12, 2021
2303259
Merge branch 'master' into feature/scribble+master
fbcouch Aug 30, 2021
fc8c9b1
Clean up some comments
fbcouch Sep 16, 2021
a9e02ae
Merge branch 'master' into feature/scribble+master
fbcouch Sep 16, 2021
3966913
Add comment explaining isCloserVertically
fbcouch Sep 24, 2021
7d75e7e
Merge branch 'master' into feature/scribble+master
fbcouch Sep 24, 2021
cbfd5b3
Fix compile error (need to add flutterTextInputView art to - updateEd…
fbcouch Sep 26, 2021
8ea77a7
Update - updateEditingClient:withDelta: in tests
fbcouch Sep 27, 2021
4ee848f
Merge branch 'master' into feature/scribble+master
fbcouch Oct 6, 2021
2dd299f
Merge branch 'master' into feature/scribble+master
fbcouch Oct 18, 2021
75e9b06
Merge branch 'feature/scribble+master' of github.com:twinsunllc/engin…
fbcouch Oct 18, 2021
99de581
Merge branch 'master' into feature/scribble+master
fbcouch Oct 26, 2021
07e195c
Incorporate feedback
fbcouch Nov 5, 2021
975177b
Merge branch 'master' into feature/scribble+master
fbcouch Nov 5, 2021
ee11699
Rename scribbleInteraction variable
fbcouch Nov 5, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename scribbleInteraction variable
  • Loading branch information
fbcouch committed Nov 5, 2021
commit ee11699bbda577bf8252d9ca54f3fe2f61a0512d
Original file line number Diff line number Diff line change
Expand Up @@ -2404,10 +2404,9 @@ - (void)setupIndirectScribbleInteraction:(id<FlutterViewResponder>)viewResponder
if (@available(iOS 14.0, *)) {
UIView* parentView = viewResponder.view;
if (parentView != nil) {
UIIndirectScribbleInteraction* _scribbleInteraction =
[[[UIIndirectScribbleInteraction alloc]
initWithDelegate:(id<UIIndirectScribbleInteractionDelegate>)self] autorelease];
[parentView addInteraction:_scribbleInteraction];
UIIndirectScribbleInteraction* scribbleInteraction = [[[UIIndirectScribbleInteraction alloc]
initWithDelegate:(id<UIIndirectScribbleInteractionDelegate>)self] autorelease];
[parentView addInteraction:scribbleInteraction];
}
}
}
Expand Down