Fixes blend + color filter #55411

gaaclarke · 2024-09-24T22:55:46Z

fixes flutter/flutter#155456

Thanks @jason-simmons for identifying the fix.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jason-simmons · 2024-09-25T16:17:27Z

Does BlendFilterContents::CreateForegroundAdvancedBlend also need this fix?

gaaclarke · 2024-09-25T16:18:47Z

Does BlendFilterContents::CreateForegroundAdvancedBlend also need this fix?

I've filed an issue for the advanced blends ( flutter/flutter#155691 ). I'm looking into it right now, this change alone doesn't fix the advanced blends.

flutter-dashboard · 2024-09-25T18:14:09Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #55411 at sha 141ff45

…155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418)" (flutter/engine#55450) 2024-09-25 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 [email protected] Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 [email protected] [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 [email protected] Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 [email protected] [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 [email protected] Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 [email protected] Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 [email protected] Fixes blend + color filter (flutter/engine#55411) 2024-09-25 [email protected] Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 [email protected] Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 [email protected] [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 [email protected] [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 [email protected] Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 [email protected] adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 [email protected] Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 [email protected] Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 [email protected] Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 [email protected] [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 [email protected] Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 [email protected] [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 [email protected] Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 [email protected] Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 [email protected] Fixes blend + color filter (flutter/engine#55411) 2024-09-25 [email protected] Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 [email protected] Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 [email protected] [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 [email protected] [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 [email protected] Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 [email protected] adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 [email protected] Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 [email protected] Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…s::CreateForegroundAdvancedBlend Some recent changes affecting color filters (flutter#55411, flutter#55448) need to be done for both Porter-Duff and advanced blend modes

…lutter#155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 [email protected] Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 [email protected] [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 [email protected] Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 [email protected] [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 [email protected] Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 [email protected] Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 [email protected] Fixes blend + color filter (flutter/engine#55411) 2024-09-25 [email protected] Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 [email protected] Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 [email protected] [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 [email protected] [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 [email protected] Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 [email protected] adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 [email protected] Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 [email protected] Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…s::CreateForegroundAdvancedBlend (#55470) Some recent changes affecting color filters (#55411, #55448) need to be done for both Porter-Duff and advanced blend modes

github-actions bot added the e: impeller label Sep 24, 2024

Fixes blend + color filter

e841620

gaaclarke force-pushed the color-filter-blend branch from e5210b3 to e841620 Compare September 24, 2024 22:56

gaaclarke mentioned this pull request Sep 25, 2024

Impeller: BlendModes don't work with ColorFilters for drawImage flutter/flutter#155456

Closed

applied jasons fix

87258f4

gaaclarke marked this pull request as ready for review September 25, 2024 15:37

oops

bf1346f

gaaclarke requested a review from jason-simmons September 25, 2024 15:39

jason-simmons approved these changes Sep 25, 2024

View reviewed changes

added golden golden

141ff45

flutter-dashboard bot added the will affect goldens label Sep 25, 2024

gaaclarke merged commit d143ca8 into flutter:main Sep 25, 2024
30 checks passed

engine-flutter-autoroll mentioned this pull request Sep 25, 2024

Roll Flutter Engine from d6d5fdba6ae1 to d143ca85f1b8 (9 revisions) flutter/flutter#155710

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

292182a

engine-flutter-autoroll mentioned this pull request Sep 25, 2024

Roll Flutter Engine from d6d5fdba6ae1 to c0b7827cf71b (10 revisions) flutter/flutter#155714

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

9b8c448

engine-flutter-autoroll mentioned this pull request Sep 25, 2024

Roll Flutter Engine from d6d5fdba6ae1 to 65305800141e (12 revisions) flutter/flutter#155718

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

8186522

engine-flutter-autoroll mentioned this pull request Sep 25, 2024

Roll Flutter Engine from d6d5fdba6ae1 to 62c0e50682e3 (14 revisions) flutter/flutter#155720

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

f17782f

engine-flutter-autoroll mentioned this pull request Sep 25, 2024

Roll Flutter Engine from d6d5fdba6ae1 to f7668afbd88e (15 revisions) flutter/flutter#155724

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

7539427

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter Engine from d6d5fdba6ae1 to 746149965de9 (16 revisions) flutter/flutter#155729

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

cf908dd

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter Engine from d6d5fdba6ae1 to 7af5b384314d (17 revisions) flutter/flutter#155730

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

d36442a

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter Engine from d6d5fdba6ae1 to 7af5b384314d (17 revisions) flutter/flutter#155731

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

2b71c7d

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter Engine from d6d5fdba6ae1 to d4850c1ae648 (18 revisions) flutter/flutter#155733

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024

d143ca85f Fixes blend + color filter (flutter/engine#55411)

5604fb6

jason-simmons mentioned this pull request Sep 26, 2024

[Impeller] Apply some recent color filter fixes to BlendFilterContents::CreateForegroundAdvancedBlend #55470

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes blend + color filter #55411

Fixes blend + color filter #55411

gaaclarke commented Sep 24, 2024 •

edited

Loading

jason-simmons commented Sep 25, 2024

gaaclarke commented Sep 25, 2024

flutter-dashboard bot commented Sep 25, 2024

Fixes blend + color filter #55411

Fixes blend + color filter #55411

Conversation

gaaclarke commented Sep 24, 2024 • edited Loading

Pre-launch Checklist

jason-simmons commented Sep 25, 2024

gaaclarke commented Sep 25, 2024

flutter-dashboard bot commented Sep 25, 2024

gaaclarke commented Sep 24, 2024 •

edited

Loading