[Impeller] Apply some recent color filter fixes to BlendFilterContents::CreateForegroundAdvancedBlend #55470
Conversation
…s::CreateForegroundAdvancedBlend Some recent changes affecting color filters (flutter#55411, flutter#55448) need to be done for both Porter-Duff and advanced blend modes
|
This issue reproduces locally on a Moto G4 using the GLES back end, and the fix has been verified on that platform. This code path only applies to devices that do not support framebuffer fetch, causing |
Ahh okay. Thanks for remembering that. We can artificially fall back to non-freambuffer fetch support by mocking out the capabilities. We've done it in the past in another test. I'll see if I can find it. So, you'd just duplicate this test, then force it to do the fallback by mocking out the capabilites. |
|
Here's how we did it in the past to force non-decal sampling support: |
|
Added the suggested test - PTAL |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jason-simmons
added
the
autosubmit
…terContents::CreateForegroundAdvancedBlend (flutter/engine#55470)
…155857) flutter/engine@f9e4ed2...9c8e5cb 2024-09-27 [email protected] [Impeller] Apply some recent color filter fixes to BlendFilterContents::CreateForegroundAdvancedBlend (flutter/engine#55470) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#155857) flutter/engine@f9e4ed2...9c8e5cb 2024-09-27 [email protected] [Impeller] Apply some recent color filter fixes to BlendFilterContents::CreateForegroundAdvancedBlend (flutter/engine#55470) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Some recent changes affecting color filters (#55411, #55448) need to be done for both Porter-Duff and advanced blend modes