[go_router_builder]: Fix Parameter generates a warning #8889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: chunhtai <[email protected]>
CaoGiaHieu-dev
changed the title
Co-authored-by: chunhtai <[email protected]>
|
Hi @CaoGiaHieu-dev you will also need to bump the version in package.yaml |
|
works well, thanks @CaoGiaHieu-dev |
|
@chunhtai is there anything else needed? |
|
could someone finally merge this please? its been in the queue forever... |
Co-authored-by: chunhtai <[email protected]>
Co-authored-by: chunhtai <[email protected]>
|
bumping this again before the tree gets out of shape yet again... |
|
looks like there is still some conflict |
|
not still, but again. because another commit was merged... this has been in the loop for almost 2 months ;( |
|
@chunhtai could you merge this, please? its been in limbo for months |
|
@vware it's not in a mergable state, as it is failing tests right now. @CaoGiaHieu-dev can you take a look at why this is failing CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: flutter/flutter#164621
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3