Skip to content

[go_router_builder]: Fix Parameter generates a warning #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
083973d
allow parse Enum with nullable String
CaoGiaHieu-dev Feb 28, 2025
b50c1b2
bump and update change log
CaoGiaHieu-dev Feb 28, 2025
454b269
reformat
CaoGiaHieu-dev Feb 28, 2025
456d6c1
reformat
CaoGiaHieu-dev Feb 28, 2025
ba31e42
Merge branch 'main' into main
CaoGiaHieu-dev Feb 28, 2025
4fdc26a
update
CaoGiaHieu-dev Feb 28, 2025
13bdc00
update
CaoGiaHieu-dev Feb 28, 2025
6281ddd
update test
CaoGiaHieu-dev Feb 28, 2025
d220bd8
update
CaoGiaHieu-dev Feb 28, 2025
31ae729
fix suffix
CaoGiaHieu-dev Mar 1, 2025
5cb1f71
Merge branch 'main' into main
CaoGiaHieu-dev Mar 1, 2025
877c5fb
Merge branch 'main' into main
CaoGiaHieu-dev Mar 3, 2025
24f5301
Update CHANGELOG.md
CaoGiaHieu-dev Mar 4, 2025
11338d8
Merge branch 'main' into main
CaoGiaHieu-dev Mar 4, 2025
6b23b9d
Merge branch 'main' into main
CaoGiaHieu-dev Mar 4, 2025
c59d3e9
Merge branch 'flutter:main' into main
CaoGiaHieu-dev Mar 19, 2025
e9180dc
fix warning
CaoGiaHieu-dev Mar 19, 2025
aad960c
fix
CaoGiaHieu-dev Mar 19, 2025
c9dcab4
fix
CaoGiaHieu-dev Mar 19, 2025
fb94d91
fix gen lints
CaoGiaHieu-dev Mar 19, 2025
689c8cb
update
CaoGiaHieu-dev Mar 19, 2025
eaf2023
update change log
CaoGiaHieu-dev Mar 19, 2025
1461d76
Update CHANGELOG.md
CaoGiaHieu-dev Mar 20, 2025
d9fa7fc
Merge branch 'main' into main
CaoGiaHieu-dev Mar 20, 2025
1cd9202
Merge branch 'main' into main
CaoGiaHieu-dev Mar 21, 2025
ce7e829
Update pubspec.yaml
CaoGiaHieu-dev Mar 22, 2025
a0e602e
Merge branch 'main' into main
CaoGiaHieu-dev Mar 29, 2025
aa41975
Merge branch 'main' into main
CaoGiaHieu-dev Apr 2, 2025
84ce9ac
Merge branch 'main' into main
CaoGiaHieu-dev Apr 9, 2025
b4830ea
Merge branch 'main' into main
CaoGiaHieu-dev Apr 12, 2025
a572081
Merge branch 'main' into main
CaoGiaHieu-dev Apr 14, 2025
34d6bf3
Update type_helpers.dart
CaoGiaHieu-dev May 2, 2025
fbc2b8e
Update type_helpers.dart
CaoGiaHieu-dev May 2, 2025
db90f8b
Merge branch 'main' into main
CaoGiaHieu-dev May 2, 2025
a9a574c
Merge branch 'main' into main
CaoGiaHieu-dev May 3, 2025
a85e984
Merge branch 'main' into main
CaoGiaHieu-dev May 6, 2025
1c8c848
Merge branch 'main' into main
CaoGiaHieu-dev May 9, 2025
871a2d2
Update pubspec.yaml
CaoGiaHieu-dev May 9, 2025
685b8e8
Merge branch 'main' into main
CaoGiaHieu-dev May 10, 2025
50c4e78
Merge branch 'main' into main
CaoGiaHieu-dev May 16, 2025
960fd08
Merge branch 'main' into main
CaoGiaHieu-dev May 23, 2025
06a0d59
Merge branch 'main' into main
CaoGiaHieu-dev Jun 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
CaoGiaHieu-dev committed Feb 28, 2025
commit 4fdc26ab158c2a7bb29cf6ec4cafe58823a50cc5
2 changes: 1 addition & 1 deletion packages/go_router_builder/lib/src/type_helpers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ abstract class _TypeHelperWithHelper extends _TypeHelper {
'${helperName(paramType)})';
}
return '${helperName(paramType)}'
'(state.${_stateValueAccess(parameterElement, pathParameters)} ${!parameterElement.isRequired ? " ?? '' " : ''})!';
'(state.${_stateValueAccess(parameterElement, pathParameters)} ${!parameterElement.isRequired ? " ?? '' " : '!'})!';
}
}

Expand Down