Skip to content

[video_player_android] Fix incorrect dimensions swap #9199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2025
Merged

[video_player_android] Fix incorrect dimensions swap #9199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a633aca
fix(video_player_android): remove incorrect width/height swap for 90/…
marvin-kolja May 4, 2025
f579d5e
fix(video_player_android): rotation layout issue (following #8685)
marvin-kolja May 4, 2025
12a98ad
feat(video_player_android): remove unused import
marvin-kolja May 4, 2025
242040e
chore(video_player_android): version bump + changelog entry
marvin-kolja May 4, 2025
817f6db
Merge branch 'main' into fix/166097
marvin-kolja May 13, 2025
4cd6ad7
chore(video_player_android): add example app fix to changelog
marvin-kolja May 13, 2025
9a03377
chore(video_player_android): add a proper link to PR ref
marvin-kolja May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into fix/166097
  • Loading branch information
@marvin-kolja
marvin-kolja committed May 13, 2025
commit 817f6dbdf650b92d7a9d1fd5fb9db54afa10d174
7 changes: 6 additions & 1 deletion packages/video_player/video_player_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
## 2.8.3
## 2.8.4

* Fixes incorrect width/height swap ([bug](https://github.com/flutter/flutter/issues/166097)). The swap was originally required for the uncorrected width/height of `Format` but was mistakenly retained after [switching to `VideoSize`](https://github.com/flutter/packages/pull/6535), which already accounts for rotation.

## 2.8.3

* Changes plugin to use `TextureRegistry.SurfaceProducer.handlesCropAndRotation` to detect
whether or not the video player rotation needs to be corrected.

## 2.8.2

* Fixes a [bug](https://github.com/flutter/flutter/issues/164689) that can cause video to
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_android
description: Android implementation of the video_player plugin.
repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.8.3
version: 2.8.4

environment:
sdk: ^3.6.0
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.