[video_player_android] Fix incorrect dimensions swap

[marvin-kolja]

Fixes flutter/flutter#166097

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[marvin-kolja]

Tested changes on an emulator using Android 15 (API 35):

Texture View before changes

Texture View after changes

Video Used

RedApple.MOV

---

Still need to test on physical devices:

• Android API <= 21
• Android API >= 29

[camsim99]

Just an FYI that I'm working on #9107, which will change the API >= 29 check (that gates the usage of Formats) to be more accurate. I'm not sure if it impacts this change, but it's just something to be aware of.

[camsim99]

Just tested out a Pixel Tablet running API 34 (handles crop and rotation automatically) and it appears to work on the main branch and in this PR (with the videos provided in the example app--not sure if this makes a difference). Will do more testing on physical devices.

[camsim99]

Why this change?

[marvin-kolja]

This is just to mirror the changes that were done in #8685 to the _VideoPlayerWithRotation of the main video_player package.

I can revert that change if it doesn't make sense in this PR...But the example is broken otherwise.

[marvin-kolja]

Just an FYI that I'm working on #9107, which will change the API >= 29 check (that gates the usage of Formats) to be more accurate. I'm not sure if it impacts this change, but it's just something to be aware of.

Thanks for bringing that up. I also thought about that, but I don't see any reason for conflict.

[marvin-kolja]

Just tested out a Pixel Tablet running API 34 (handles crop and rotation automatically) and it appears to work on the main branch and in this PR (with the videos provided in the example app--not sure if this makes a difference). Will do more testing on physical devices.

Appreciate it! They will definitely reflect if this PR messed anything up with videos that do not need a rotation, but I don't think any of the example videos require rotation to begin with. Maybe we can add a new video that would meet that requirement?