Skip to content

Ignore .cxx/ directories #9268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

Conversation

stuartmorgan-g
Copy link
Contributor

Android builds now create .cxx directories in some cases; this has been added to the app template's ignore file, so should be ignored here as well. As is generally the case for this repo, we ignore it at the root level instead of updating every package.

Android builds now create .cxx directories in some cases; this has been
added to the app template's ignore file, so should be ignored here as
well. As is generally the case for this repo, we ignore it at the root
level instead of updating every package.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Contributor Author

test-exempt: configuration change

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025
Copy link
Contributor

auto-submit bot commented May 16, 2025

autosubmit label was removed for flutter/packages/9268, because - The status or check suite Linux_web web_platform_tests_shard_3 stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025
Copy link
Contributor

auto-submit bot commented May 21, 2025

autosubmit label was removed for flutter/packages/9268, because - The status or check suite Linux_web web_platform_tests_shard_3 stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025
@auto-submit auto-submit bot merged commit 69889c9 into flutter:main May 21, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request May 27, 2025
flutter/packages@af0b9a9...6eebe72

2025-05-27 [email protected] [flutter_lints] Bump lints dependency to
6.0.0 and bump package to 6.0.0 (flutter/packages#9108)
2025-05-26 [email protected] Roll Flutter from
60050a0 to 4372bfb (6 revisions) (flutter/packages#9322)
2025-05-26 [email protected] [video_player_android] Add note
about Android platform views known issue (flutter/packages#9312)
2025-05-24 [email protected] Roll Flutter from
85564cb to 60050a0 (17 revisions) (flutter/packages#9318)
2025-05-23 [email protected]
[camera_android_camerax] Implement `enableAudio` for video recording
(flutter/packages#9264)
2025-05-23 [email protected]
[video_player_android] isBuffering flag always return true after calling
seekTo method - fixed (flutter/packages#9198)
2025-05-23 [email protected] [camera,video_player] replace
onSurfaceDestroyed with onSurfaceCleanup (flutter/packages#9316)
2025-05-23 [email protected] [camera,video_player] Update Android
to 3.29 minimum (flutter/packages#9317)
2025-05-23 [email protected] Roll Flutter from
33cdd8e to 85564cb (39 revisions) (flutter/packages#9315)
2025-05-23 [email protected] Update repo for 3.32 stable
(flutter/packages#9311)
2025-05-23 [email protected] [camera_avfoundation] Correct
pigeon configuration output paths (flutter/packages#9313)
2025-05-23 [email protected] [process] Remove from the repository
(flutter/packages#9310)
2025-05-22 [email protected] Ensure Example Packages Work on
Android API 36 (flutter/packages#9241)
2025-05-22 [email protected] Roll Flutter (stable) from
c236373 to be698c4 (1274 revisions) (flutter/packages#9300)
2025-05-22 [email protected] Remove CODEOWNER for generated iOS files
(flutter/packages#9272)
2025-05-22 [email protected]
[google_maps_flutter] Removes unnecessary parentheses
(flutter/packages#9273)
2025-05-21 [email protected] Rebalance Android plugin CODEOWNERS
(flutter/packages#9298)
2025-05-21 [email protected] Roll Flutter from
9a78af5 to 33cdd8e (60 revisions) (flutter/packages#9305)
2025-05-21 [email protected] [ci] Update repository for 3.29
release (flutter/packages#9270)
2025-05-21 [email protected] Ignore .cxx/ directories
(flutter/packages#9268)
2025-05-21 [email protected] [video_player] Skip some integration
tests on web (flutter/packages#9302)
2025-05-21 [email protected]
[webview_flutter] Adds support to respond to recoverable SSL certificate
errors (flutter/packages#9150)
2025-05-19 [email protected]
[camera_android_camerax] Swap out `BroadcastReceiver` for
`OrientationEventListener` (flutter/packages#9261)
2025-05-19 [email protected]
[video_player_android] Fix incorrect dimensions swap
(flutter/packages#9199)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
Android builds now create .cxx directories in some cases; this has been added to the app template's ignore file, so should be ignored here as well. As is generally the case for this repo, we ignore it at the root level instead of updating every package.
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
Android builds now create .cxx directories in some cases; this has been added to the app template's ignore file, so should be ignored here as well. As is generally the case for this repo, we ignore it at the root level instead of updating every package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants