Skip to content

Debian 11 support #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Conversation

smallsam
Copy link
Contributor

@smallsam smallsam commented Aug 17, 2021

Debian 11/bullseye vars and adding to ci

Fixes #469

@SchizoDuckie
Copy link

As far as I can tell, the check in setup-Debian.yml will fail as the default package installs mariadb, which does NOT create a file in /etc/init.d, leading to idempotency errors and deleted innodb logfiles because the role thinks it's always just installed the service.

suggested fix:

#setup-Debian.yml
- name: Check if MySQL is already installed.
  stat: "path=/etc/init.d/{{ mysql_daemon }}"
  register: mysql_installed
#Debian11.yaml
__mysql_daemon: mariadb

@domrim
Copy link

domrim commented Dec 16, 2021

can confirm @SchizoDuckie . without these changes the role doesn't run idempotent, with them it does. can sb fix this and get this ready to merge? Debian 11 gets more important every day for us.

@domrim domrim mentioned this pull request Dec 17, 2021
@smallsam
Copy link
Contributor Author

Thanks @SchizoDuckie and @domrim I've incorporated this fix here now.

@geerlingguy geerlingguy merged commit a56a482 into geerlingguy:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing Debian 11 vars
5 participants