Fix idempotence for Debian 11 and Debian 10 tests #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heh... so idempotence breaks on debian 10 without the change, but breaks on debian 11 with the change. Drat. |
|
What is that check even for? Maybe a better check is needed. It's been a while, but I think it's checking for an initv script... which is probably not even a thing on Debian 11. |
|
FYI just checked on a fresh install it seems that the file has been renamed to /etc/init.d/mariadb on debian11 |
|
@ak4t0sh - So in that case, it needs to check for a file named |
geerlingguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that #457 may have broken idempotence on Debian 10. Testing to see if that's the case. Don't want to tag broken code in a new release...