Skip to content

Change definition of getFactoryNodeInternal #19359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove type enforcement on the TValueNode
  • Loading branch information
jeongsoolee09 committed May 5, 2025
commit c327e6ff070e172b83c9692981962704cc470214
4 changes: 1 addition & 3 deletions javascript/ql/lib/semmle/javascript/AMD.qll
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,7 @@ class AmdModuleDefinition extends CallExpr instanceof AmdModuleDefinition::Range
Function getFactoryFunction() { TValueNode(result) = this.getFactoryNodeInternal() }

private EarlyStageNode getFactoryNodeInternal() {
exists(Function factoryFunction | factoryFunction = this.getArgument(_) |
result = TValueNode(factoryFunction)
)
result = TValueNode(this.getArgument(_))
or
DataFlow::localFlowStep(result, this.getFactoryNodeInternal())
}
Expand Down