-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Change definition of getFactoryNodeInternal
#19359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeongsoolee09
wants to merge
5
commits into
main
Choose a base branch
from
jeongsoolee09/refine-amdmodule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
06e3a01
Change definition of `getFactoryNodeInternal`
jeongsoolee09 f0dfa51
Dynamically determine the callback argument's position
jeongsoolee09 c327e6f
Remove type enforcement on the TValueNode
jeongsoolee09 44b1bc9
Merge branch 'main' into jeongsoolee09/refine-amdmodule
jeongsoolee09 2931b95
Merge branch 'main' into jeongsoolee09/refine-amdmodule
jeongsoolee09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Dynamically determine the callback argument's position
An additional parameter may be anywhere in the parameter list and shift around the exact index of the callback argument in the parameter list. So, "dynamically" determine the index by type-checking a parameter in the parameter list. Note 1: There may be multiple matches since we're using `_` (don't care) as the argument index. Note 2: We could have used DataFlow::InvokeNode.getCallback if the supertype were not CallExpr, but jumping to data flow node is an overkill here.
- Loading branch information
commit f0dfa51fb9e10fb61130fbc5e30718916c421826
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The restriction to
Function
here is too restrictive as we may need to follow some local flow steps before we get to the function (see the recursive case below). Some tests are failing because of this. Could you try simply changinggetLastArgument()
togetArgument(_)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the construction of
TValueNode
toTValueNode(this.getArgument(_))
.