Skip to content

refactor: Replace 'println' with 'fmt.Println' #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandear
Copy link
Contributor

The PR replaces println with normal fmt.Println in the example/tokenauth.

println is not guaranteed to stay in the language according to the spec.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.
Merging.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.29%. Comparing base (2b8c7fa) to head (25eeb6f).
Report is 147 commits behind head on master.

Files with missing lines Patch % Lines
example/tokenauth/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3326      +/-   ##
==========================================
- Coverage   97.72%   93.29%   -4.43%     
==========================================
  Files         153      171      +18     
  Lines       13390    11729    -1661     
==========================================
- Hits        13085    10943    -2142     
- Misses        215      692     +477     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis merged commit 0259e62 into google:master Oct 11, 2024
5 of 7 checks passed
@alexandear alexandear deleted the refactor/example-avoid-println branch October 12, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants