Skip to content

refactor: Replace 'print' with 'fmt.Print' #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Oct 14, 2024

The PR replaces print with normal fmt.Print in the test directory.

print is not guaranteed to stay in the language according to the spec.

These changes are similar to those in #3326.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.
Merging.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.39%. Comparing base (2b8c7fa) to head (5ab40ba).
Report is 153 commits behind head on master.

Files with missing lines Patch % Lines
test/fields/fields.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3327      +/-   ##
==========================================
- Coverage   97.72%   93.39%   -4.33%     
==========================================
  Files         153      172      +19     
  Lines       13390    11909    -1481     
==========================================
- Hits        13085    11123    -1962     
- Misses        215      692     +477     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis merged commit 8ea16b9 into google:master Oct 14, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants