Skip to content

fix: LabelEncoder params consistent with Sklearn #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments for base LabelTransformer
  • Loading branch information
ashleyxuu committed Sep 25, 2023
commit a77c978f8bc8366bfa00d0a63149912be28a9fef
4 changes: 2 additions & 2 deletions bigframes/ml/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def fit_transform(


class LabelTransformer(BaseEstimator):
"""A BigQuery DataFrames Transformer base class that transforms data.
"""A BigQuery DataFrames Label Transformer base class that transforms data.

Also the transformers can be attached to a pipeline with a predictor."""

Expand All @@ -212,6 +212,6 @@ def transform(self, y):

def fit_transform(
self,
y: Optional[Union[bpd.DataFrame, bpd.Series]] = None,
y: Optional[Union[bpd.DataFrame, bpd.Series]],
) -> bpd.DataFrame:
return self.fit(y).transform(y)