Skip to content

Add SourceLink, embedded readme, implicit usings; refactor project properties #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2022
Merged

Add SourceLink, embedded readme, implicit usings; refactor project properties #416

merged 3 commits into from
Jul 18, 2022

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Jul 16, 2022 •
edited
Loading

I need to debug one of our services that uses graphql-client.

@sungam3r sungam3r requested review from rose-a and Shane32 July 16, 2022 07:40
@sungam3r sungam3r self-assigned this Jul 16, 2022
@sungam3r sungam3r added enhancement New feature or request CI CI configuration issue or pull request labels Jul 16, 2022
Shane32
Shane32 requested changes Jul 17, 2022
View reviewed changes
rose-a
rose-a requested changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@rose-a rose-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build generates packages for GraphQL.Server.Test and IntegrationTestServer now.

Please disable package generation for those (now enabled because of <IsPackable>true</IsPackable> in Directory.Build.props)

@sungam3r
Copy link
Member Author

Done. Forgot to set IsPackable to false.

@rose-a rose-a merged commit 9ca13c2 into master Jul 18, 2022
@rose-a rose-a deleted the sourcelink branch July 18, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shane32 Shane32 Shane32 requested changes

@rose-a rose-a rose-a requested changes

Assignees

@sungam3r sungam3r

Labels
CI CI configuration issue or pull request enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sungam3r @Shane32 @rose-a