Add SourceLink, embedded readme, implicit usings; refactor project properties

Directory.Build.props

@@ -0,0 +1,33 @@
+<Project>
+
+  <PropertyGroup>
+    <Authors>Deinok,Alexander Rose,graphql-dotnet</Authors>
+    <Description>A GraphQL Client for .NET Standard</Description>
+    <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <LangVersion>latest</LangVersion>
+    <NeutralLanguage>en-US</NeutralLanguage>
+    <NoWarn>$(NoWarn);NU5105</NoWarn> <!--TODO: fix-->
+    <NoWarn>$(NoWarn);1591</NoWarn> <!--TODO: write comments to public APIs-->
+    <Nullable>annotations</Nullable>
+    <PackageIcon>logo.64x64.png</PackageIcon>
+    <PackageLicenseExpression>MIT</PackageLicenseExpression>
+    <PackageProjectUrl>https://github.com/graphql-dotnet/graphql-client</PackageProjectUrl>
+    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
+    <PackageTags>GraphQL</PackageTags>
+    <RepositoryType>git</RepositoryType>
+    <PublishRepositoryUrl>true</PublishRepositoryUrl>
+    <Deterministic>true</Deterministic>
+    <!-- https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables -->
+    <!-- https://github.com/clairernovotny/DeterministicBuilds -->
+    <ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild>
+    <DebugType>embedded</DebugType>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
+    <WarningLevel>4</WarningLevel>
+    <IsPackable>true</IsPackable>
+  </PropertyGroup>
+
+</Project>

src/src.props → Directory.Build.targets

@@ -1,20 +1,12 @@
 <Project>
 
-  <Import Project="../root.props" />
-
-  <PropertyGroup>
-    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-    <LangVersion>8.0</LangVersion>
+  <PropertyGroup Condition="'$(IsPackable)' == 'true'">
+    <PackageReadmeFile>README.md</PackageReadmeFile>
+    <!--<Nullable>enable</Nullable>--> <!--TODO-->
+    <GeneratePackageOnBuild>true</GeneratePackageOnBuild> <!--TODO: remove? since generated on CI-->
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Update="GitVersionTask" Version="5.6.7">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
-  </ItemGroup>
-
-  <PropertyGroup Condition=" '$(GitVersion_SemVer)' != ''">
+  <PropertyGroup Condition="'$(IsPackable)' == 'true' AND '$(GitVersion_SemVer)' != ''">
     <GetVersion>false</GetVersion>
     <WriteVersionInfoToBuildLog>false</WriteVersionInfoToBuildLog>
     <UpdateAssemblyInfo>false</UpdateAssemblyInfo>
@@ -33,4 +25,19 @@
     <RepositoryCommit Condition=" '$(RepositoryCommit)' == '' ">$(GitVersion_Sha)</RepositoryCommit>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(IsPackable)' != 'true'">
+    <NoWarn>$(NoWarn);1591</NoWarn>
+  </PropertyGroup>
+
+  <ItemGroup Condition="'$(IsPackable)' == 'true'">
+    <None Include="..\..\assets\logo.64x64.png" Pack="true" PackagePath="\" />
+    <None Include="..\..\README.md" Pack="true" PackagePath="\" />
+    <None Include="..\..\LICENSE.txt" Pack="true" PackagePath="\" />
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
+    <PackageReference Update="GitVersionTask" Version="5.6.7">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
+
 </Project>

GraphQL.Client.sln

@@ -4,26 +4,21 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 VisualStudioVersion = 17.1.32228.430
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{47C98B55-08F1-4428-863E-2C5C876DEEFE}"
-	ProjectSection(SolutionItems) = preProject
-		src\.editorconfig = src\.editorconfig
-		src\src.props = src\src.props
-	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{63F75859-4698-4EDE-8B70-4ACBB8BC425A}"
 	ProjectSection(SolutionItems) = preProject
 		.editorconfig = .editorconfig
 		.gitignore = .gitignore
+		Directory.Build.props = Directory.Build.props
+		Directory.Build.targets = Directory.Build.targets
 		dotnet-tools.json = dotnet-tools.json
 		LICENSE.txt = LICENSE.txt
 		examples\GraphQL.Client.Example\Program.cs = examples\GraphQL.Client.Example\Program.cs
 		README.md = README.md
-		root.props = root.props
+		tests\tests.props = tests\tests.props
 	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{0B0EDB0F-FF67-4B78-A8DB-B5C23E1FEE8C}"
-	ProjectSection(SolutionItems) = preProject
-		tests\tests.props = tests\tests.props
-	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "assets", "assets", "{6326E0E2-3F48-4BAF-80D3-47AED5EB647C}"
 	ProjectSection(SolutionItems) = preProject

examples/GraphQL.Client.Example/Program.cs

@@ -7,7 +7,7 @@
 
 namespace GraphQL.Client.Example
 {
-    public class Program
+    public static class Program
     {
         public static async Task Main()
         {

src/GraphQL.Client.Abstractions.Websocket/GraphQL.Client.Abstractions.Websocket.csproj

@@ -1,7 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <Import Project="../src.props" />
-
   <PropertyGroup>
     <Description>Abstractions for the Websocket transport used in GraphQL.Client</Description>
     <TargetFramework>netstandard2.0</TargetFramework>

src/GraphQL.Client.Abstractions.Websocket/GraphQLWebSocketRequest.cs

@@ -1,7 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Threading.Tasks;
-
 namespace GraphQL.Client.Abstractions.Websocket
 {
     /// <summary>

src/GraphQL.Client.Abstractions.Websocket/GraphQLWebSocketResponse.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Collections.Generic;
-
 namespace GraphQL.Client.Abstractions.Websocket
 {
     /// <summary>

src/GraphQL.Client.Abstractions.Websocket/IGraphQLWebsocketJsonSerializer.cs

@@ -1,6 +1,3 @@
-using System.IO;
-using System.Threading.Tasks;
-
 namespace GraphQL.Client.Abstractions.Websocket
 {
     /// <summary>

src/GraphQL.Client.Abstractions/GraphQL.Client.Abstractions.csproj

@@ -1,7 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <Import Project="../src.props" />
-
   <PropertyGroup>
     <Description>Abstractions for GraphQL.Client</Description>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>

src/GraphQL.Client.Abstractions/GraphQLClientExtensions.cs

@@ -1,7 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
-
 namespace GraphQL.Client.Abstractions
 {
     public static class GraphQLClientExtensions

src/GraphQL.Client.Abstractions/GraphQLJsonSerializerExtensions.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace GraphQL.Client.Abstractions
 {
     public static class GraphQLJsonSerializerExtensions

src/GraphQL.Client.Abstractions/IGraphQLClient.cs

@@ -1,7 +1,4 @@
-using System;
 using System.Net.WebSockets;
-using System.Threading;
-using System.Threading.Tasks;
 
 namespace GraphQL.Client.Abstractions
 {

src/GraphQL.Client.Abstractions/IGraphQLJsonSerializer.cs

@@ -1,7 +1,3 @@
-using System.IO;
-using System.Threading;
-using System.Threading.Tasks;
-
 namespace GraphQL.Client.Abstractions
 {
     public interface IGraphQLJsonSerializer

src/GraphQL.Client.Abstractions/Utilities/StringExtensions.cs

@@ -1,6 +1,4 @@
-using System.Collections.Generic;
-
-namespace GraphQL.Client.Abstractions.Utilities
+namespace GraphQL.Client.Abstractions.Utilities
 {
     /// <summary>
     /// Copied from https://github.com/jquense/StringUtils

src/GraphQL.Client.Abstractions/Utilities/StringUtils.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text.RegularExpressions;
+using System.Text.RegularExpressions;
 
 namespace GraphQL.Client.Abstractions.Utilities
 {

src/GraphQL.Client.LocalExecution/GraphQL.Client.LocalExecution.csproj

@@ -1,7 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <Import Project="../src.props" />
-
   <PropertyGroup>
     <Description>A GraphQL Client which executes the queries directly on a provided GraphQL schema using graphql-dotnet</Description>
     <TargetFramework>netstandard2.0</TargetFramework>

src/GraphQL.Client.LocalExecution/GraphQLLocalExecutionClient.cs

@@ -1,10 +1,5 @@
-using System;
-using System.IO;
-using System.Linq;
 using System.Reactive.Linq;
 using System.Reactive.Threading.Tasks;
-using System.Threading;
-using System.Threading.Tasks;
 using GraphQL.Client.Abstractions;
 using GraphQL.Types;
 

src/GraphQL.Client.Serializer.Newtonsoft/ConstantCaseEnumConverter.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Linq;
 using System.Reflection;
 using GraphQL.Client.Abstractions.Utilities;
 using Newtonsoft.Json;

src/GraphQL.Client.Serializer.Newtonsoft/GraphQL.Client.Serializer.Newtonsoft.csproj

@@ -1,7 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <Import Project="../src.props" />
-
   <PropertyGroup>
     <Description>A serializer implementation for GraphQL.Client using Newtonsoft.Json as underlying JSON library</Description>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>

src/GraphQL.Client.Serializer.Newtonsoft/MapConverter.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 

src/GraphQL.Client.Serializer.Newtonsoft/NewtonsoftJsonSerializer.cs

@@ -1,8 +1,4 @@
-using System;
-using System.IO;
 using System.Text;
-using System.Threading;
-using System.Threading.Tasks;
 using GraphQL.Client.Abstractions;
 using GraphQL.Client.Abstractions.Websocket;
 using Newtonsoft.Json;

src/GraphQL.Client.Serializer.SystemTextJson/ConverterHelperExtensions.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Buffers;
 using System.Numerics;
 using System.Text;

src/GraphQL.Client.Serializer.SystemTextJson/ErrorPathConverter.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 

src/GraphQL.Client.Serializer.SystemTextJson/GraphQL.Client.Serializer.SystemTextJson.csproj

@@ -1,7 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <Import Project="../src.props" />
-
   <PropertyGroup>
     <Description>A serializer implementation for GraphQL.Client using System.Text.Json as underlying JSON library</Description>
     <TargetFrameworks>netstandard2.0;netcoreapp3.1</TargetFrameworks>

src/GraphQL.Client.Serializer.SystemTextJson/ImmutableConverter.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Text.Json;

src/GraphQL.Client.Serializer.SystemTextJson/MapConverter.cs

@@ -1,7 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Numerics;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 

src/GraphQL.Client.Serializer.SystemTextJson/SystemTextJsonSerializer.cs

@@ -1,9 +1,5 @@
-using System;
-using System.IO;
 using System.Text.Json;
 using System.Text.Json.Serialization;
-using System.Threading;
-using System.Threading.Tasks;
 using GraphQL.Client.Abstractions;
 using GraphQL.Client.Abstractions.Websocket;
 

src/GraphQL.Client/GraphQL.Client.csproj

@@ -1,7 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <Import Project="../src.props" />
-
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
     <RootNamespace>GraphQL.Client.Http</RootNamespace>

src/GraphQL.Client/GraphQLHttpClient.cs

@@ -1,11 +1,5 @@
-using System;
 using System.Diagnostics;
-using System.IO;
-using System.Linq;
-using System.Net.Http;
 using System.Net.Http.Headers;
-using System.Threading;
-using System.Threading.Tasks;
 using GraphQL.Client.Abstractions;
 using GraphQL.Client.Abstractions.Websocket;
 using GraphQL.Client.Http.Websocket;
@@ -110,7 +104,7 @@ public IObservable<GraphQLResponse<TResponse>> CreateSubscriptionStream<TRespons
         #endregion
 
         /// <summary>
-        /// explicitly opens the websocket connection. Will be closed again on disposing the last subscription
+        /// Explicitly opens the websocket connection. Will be closed again on disposing the last subscription.
         /// </summary>
         /// <returns></returns>
         public Task InitializeWebsocketConnection() => GraphQlHttpWebSocket.InitializeWebSocket();

src/GraphQL.Client/GraphQLHttpClientExtensions.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Net.WebSockets;
 using GraphQL.Client.Abstractions;
 

src/GraphQL.Client/GraphQLHttpClientOptions.cs

@@ -1,13 +1,10 @@
-using System;
-using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Net.WebSockets;
-using System.Threading.Tasks;
 
 namespace GraphQL.Client.Http
 {
     /// <summary>
-    /// The Options that the <see cref="GraphQLHttpClient"/> will use
+    /// The Options that the <see cref="GraphQLHttpClient"/> will use.
     /// </summary>
     public class GraphQLHttpClientOptions
     {

src/GraphQL.Client/GraphQLHttpRequest.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Net.Http;
 using System.Runtime.Serialization;
 using System.Text;
 using GraphQL.Client.Abstractions;