haskell-yas.el should be a separate package

[Fanael]

As per #356 (comment). The bugtracker is usually the best place to track TODOs like this.

[purcell]

Thanks for filing this.

Specifically, this would involve adding a Package-Requires header to haskell-yas so that it depends on haskell-mode and yasnippet. It could then be built into a separate package on MELPA, and not included in haskell-mode itself. And we'd need to check that haskell-mode still compiled/worked fine without haskell-yas.el.

In my experience, the best way to handle this sort of thing is to put the separate package in a separate git repository to avoid confusion.

[gracjan]

@purcell, for the record haskell-yas seems to be a rename of shnippet that is alive and well in a github report maintained by shippet author: https://github.com/LukeHoersten/shnippet. haskell-yas does not offer any functionality over what shnippet offers.

[gracjan]

For posterity reference accidental issues that one of users experienced: #305.

[lukehoersten]

I actively maintain both shnippet and snippet/haskell-mode (they are the same just a rename). The reason it was originally moved into haskell-mode was because it allows us to have completions like lang that use haskell-mode to expand to all possible lang pragmas. YAS itself comes packaged with some basic haskell completions as well.

I'm not sure if the best course of action is to:

1. kill off my external repo and just manage through haskell-mode
2. try to get these merged into YAS proper and just have the haskell-mode dependent snippets say in haskell-mode like lang expansion.
3. Use subrepos and link back to my schnippet repo

Either way I think we've decided the haskell-yas.el file needs to be it's own package right? Do we just want to bundle the snippets with that then?

What do you guys think?

[gracjan]

If snippets are to be fully supported citizen of haskell-mode there needs to be documentation for that and description how to enable those.

[purcell]

I personally strongly feel that haskell-yas should disappear, and there should just be a properly-packaged version of schnippet, or a derivative thereof, ideally under the haskell github org.

There's no fundamental connection between the haskell snippets and haskell-mode in terms of code. yasnippet has to be installed separately from haskell-mode anyway, and many people don't use it at all. Packaging optional extras separately is the right thing to do in these days of pervasive Emacs package management.

[purcell]

To clarify, it may of course make sense for schnippet to depend on haskell-mode in order to provide correct snippets, but no part of haskell-mode needs haskell-yas/schnippet.

[lukehoersten]

I think that's the right approach Steve. Moving it to the Haskell github
would alleviate a lot of the questions I've seen too about what's the
officially supported version. I'll do that soon. Thanks for the feedback.
On Wed, Apr 22, 2015 at 12:22 PM Steve Purcell [email protected]
wrote:

To clarify, it may of course make sense for schnippet to depend on
haskell-mode in order to provide correct snippets, but no part of
haskell-mode needs haskell-yas/schnippet.

—
Reply to this email directly or view it on GitHub
#361 (comment)
.

[lukehoersten]

https://github.com/haskell/haskell-snippets