Skip to content

Introduce declarations to haskell-yas.el so it byte-compiles cleanly. #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Fanael
Copy link
Contributor

@Fanael Fanael commented Oct 13, 2014

Without them:

In haskell-snippets-initialize:
haskell-yas.el:60:17:Warning: reference to free variable `yas-snippet-dirs'
haskell-yas.el:61:23:Warning: assignment to free variable `yas-snippet-dirs'

In end of data:
haskell-yas.el:73:1:Warning: the function `yas-load-directory' is not known to
    be defined.

@purcell
Copy link
Member

purcell commented Oct 13, 2014

I understand the motivation, but do you think this is worthwhile? I personally don't mind seeing these particular warnings because they're a reminder that there's a missing package dependency. haskell-yas should really be a separate package.

@Fanael
Copy link
Contributor Author

Fanael commented Oct 13, 2014

Oh, okay then.

@Fanael Fanael closed this Oct 13, 2014
@Fanael
Copy link
Contributor Author

Fanael commented Oct 13, 2014

I mean, as a user I like to see packages compile cleanly[1], but it seems there's a good reason in this case.

  1. Unlike say smartparens, where byte compilation reveals some real bugs.

@purcell
Copy link
Member

purcell commented Oct 13, 2014

Unlike say smartparens

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants