Skip to content

Provide access to the contextual data map #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavideD opened this issue Apr 16, 2025 · 1 comment · Fixed by #2217 or #2218
Closed

Provide access to the contextual data map #2207

DavideD opened this issue Apr 16, 2025 · 1 comment · Fixed by #2217 or #2218
Assignees
@DavideD
Labels
quarkus The issue links an issue in Quarkus regression Something that was working before. A test that we have disabled
Milestone
3.0.0.CR1

Comments

@DavideD
Copy link
Member

DavideD commented Apr 16, 2025 •
edited
Loading

These are the changes:

We introduced them when we worked on #2176 and #2174, but they are causing a regression in Quarkus:
quarkusio/quarkus#47314

I will try to have a look and see if I can figure out what's going on, but, if we cannot find a solution, I think it's better to revert the changes and applies them again later
@DavideD DavideD added quarkus The issue links an issue in Quarkus regression Something that was working before. A test that we have disabled labels Apr 16, 2025
@DavideD DavideD added this to the 3.0.0.CR1 milestone Apr 16, 2025
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Apr 21, 2025
@gavinking
[hibernate#2207] fix cast to ReactiveSession that broke StatelessSession
fa6042c
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Apr 21, 2025
@gavinking
[hibernate#2207] fix cast to ReactiveSession that broke StatelessSession
9736346
@DavideD
Copy link
Member Author

DavideD commented Apr 24, 2025

We actually have a solution for this, so I will just fix the issue

@DavideD DavideD self-assigned this Apr 24, 2025
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 24, 2025
@DavideD
[hibernate#2207] Provide access to the contextual data map
bec6223 
We store the session in the Vert.x local context.

But, Quarkus needs a way to access the same context when
using Panache.

See quarkus issue: quarkusio/quarkus#47314
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 24, 2025
@DavideD
[hibernate#2207] Provide access to the contextual data map
4535bf3 
We store the session in the Vert.x local context.

But, Quarkus needs a way to access the same context when
using Panache.

See quarkus issue: quarkusio/quarkus#47314
This was referenced Apr 24, 2025
Merged
Merged
@DavideD DavideD linked a pull request Apr 24, 2025 that will close this issue
[2.4] Provide access to the contextual data map #2218
Merged
DavideD added a commit to DavideD/quarkus that referenced this issue Apr 24, 2025
@DavideD
Update access to the Vert.x local context for Panache
fc757f0 
In preparation to the upgrade to Vertx. 5, Hibernate Reactive
doesn't use anymore the deprecated API to access the local context.

This commits updates the way Panache access the context so that the
two extensions can comunicate.

Fix quarkusio#47314
Relats to the Hibernate Reactive issues:
* hibernate/hibernate-reactive#2176
* hibernate/hibernate-reactive#2174
* hibernate/hibernate-reactive#2207
DavideD added a commit that referenced this issue Apr 24, 2025
@DavideD
[#2207] Provide access to the contextual data map
02db560 
We store the session in the Vert.x local context.

But, Quarkus needs a way to access the same context when
using Panache.

See quarkus issue: quarkusio/quarkus#47314
DavideD added a commit that referenced this issue Apr 24, 2025
@DavideD
[#2207] Provide access to the contextual data map
80a9cfe 
We store the session in the Vert.x local context.

But, Quarkus needs a way to access the same context when
using Panache.

See quarkus issue: quarkusio/quarkus#47314
@DavideD DavideD changed the title Revert changes to the contextual data storage Provide access to the contextual data map Apr 30, 2025
@DavideD DavideD mentioned this issue Apr 30, 2025
Closed
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "[hibernate#2207] Provide access to the conte…
2707b6d 
…xtual data map"

This reverts commit 02db560.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "[hibernate#2207] Provide access to the conte…
e10733a 
…xtual data map"

This reverts commit 80a9cfe.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "[#2207] Provide access to the contextual data map"
7729009 
This reverts commit 02db560.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "[#2207] Provide access to the contextual data map"
59205e2 
This reverts commit 80a9cfe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
quarkus The issue links an issue in Quarkus regression Something that was working before. A test that we have disabled
Projects
None yet
Milestone
3.0.0.CR1
1 participant
@DavideD