Skip to content

Revert the changes in preparation of Vert.x 5 #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavideD opened this issue Apr 30, 2025 · 0 comments · Fixed by #2235 or #2236
Closed

Revert the changes in preparation of Vert.x 5 #2234

DavideD opened this issue Apr 30, 2025 · 0 comments · Fixed by #2235 or #2236
Labels
quarkus The issue links an issue in Quarkus
Milestone
3.0.0.CR1

Comments

@DavideD
Copy link
Member

DavideD commented Apr 30, 2025 •
edited
Loading

In preparation of Vert.x 5, we replace the use of some deprecated API.

The problem is that it seems that the approach we are using is not the right one.

As far as I understand, there isn't a right a way to do what we need right now. So, I'm going to revert the original changes and keep using the deprecated API until Vert.x 5 has a new API we can use.

This will also solve quarkusio/quarkus#47314
@DavideD DavideD added the quarkus The issue links an issue in Quarkus label Apr 30, 2025
@DavideD DavideD added this to the 3.0.0.CR1 milestone Apr 30, 2025
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "[hibernate#2207] Provide access to the conte…
2707b6d 
…xtual data map"

This reverts commit 02db560.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "Make CONTEXTUAL_DATA_KEY constant"
dd5586e 
This reverts commit feb4c27.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "[hibernate#2176] Create custom Vert.x contex…
d11686f 
…tual data storage"

This reverts commit 95ad44c.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "[hibernate#2174] Prepare for Vert.x 5 upgrad…
9e6e834 
…e in Vert.x Context"

This reverts commit 147604a.
@DavideD DavideD mentioned this issue Apr 30, 2025
Merged
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "[hibernate#2207] Provide access to the conte…
e10733a 
…xtual data map"

This reverts commit 80a9cfe.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "Make CONTEXTUAL_DATA_KEY constant"
7b54fcf 
This reverts commit 156f7c3.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "[hibernate#2176] Create custom Vert.x contex…
c304230 
…tual data storage"

This reverts commit b4ab6a4.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 30, 2025
@DavideD
[hibernate#2234] Revert "[hibernate#2174] Prepare for Vert.x 5 upgrad…
5cb1a9e 
…e in Vert.x Context"

This reverts commit 742ab0b.
@DavideD DavideD mentioned this issue Apr 30, 2025
Merged
@DavideD DavideD linked a pull request Apr 30, 2025 that will close this issue
[2.4] Revert changes in preparation of Vert.x 5 #2236
Merged
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "[#2207] Provide access to the contextual data map"
7729009 
This reverts commit 02db560.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "Make CONTEXTUAL_DATA_KEY constant"
070adfa 
This reverts commit feb4c27.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "[#2176] Create custom Vert.x contextual data storage"
8ef08d5 
This reverts commit 95ad44c.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "[#2174] Prepare for Vert.x 5 upgrade in Vert.x Context"
4d5ac00 
This reverts commit 147604a.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "[#2207] Provide access to the contextual data map"
59205e2 
This reverts commit 80a9cfe.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "Make CONTEXTUAL_DATA_KEY constant"
ab6aa32 
This reverts commit 156f7c3.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "[#2176] Create custom Vert.x contextual data storage"
54414d1 
This reverts commit b4ab6a4.
DavideD added a commit that referenced this issue Apr 30, 2025
@DavideD
[#2234] Revert "[#2174] Prepare for Vert.x 5 upgrade in Vert.x Context"
02c825a 
This reverts commit 742ab0b.
@DavideD DavideD marked this as a duplicate of #2229 Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quarkus The issue links an issue in Quarkus
Projects
None yet
Milestone
3.0.0.CR1
1 participant
@DavideD