Tidy up yaml configs #121
Merged
Tidy up yaml configs #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliberts
approved these changes
Apr 30, 2024
Comment on lines
-3
to
-9
| eval_episodes: 50 | ||
| eval_freq: 7500 | ||
| save_freq: 75000 | ||
| log_freq: 250 | ||
| # TODO: same as xarm, need to adjust | ||
| offline_steps: 25000 | ||
| online_steps: 25000 |
There was a problem hiding this comment.
I'm a bit confused, were these used before?
Which took priority between those values and the ones in the policies yaml?
aliberts
added
refactor
menhguin
pushed a commit
to menhguin/lerobot
that referenced
this pull request
Feb 9, 2025
Kalcy-U
referenced
this pull request
in Kalcy-U/lerobot
May 13, 2025
ZoreAnuj
pushed a commit
to luckyrobots/lerobot
that referenced
this pull request
Jul 29, 2025
Ricci084
pushed a commit
to JeffWang987/lerobot
that referenced
this pull request
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Not covered in this PR
TD-MPC will be broken, but it has been for a while now I think. A PR is about to land to fix that.
How was it tested?
Tests were updated. I also tried a few steps of a training run for DP and ACT, including eval during training.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR. Try to avoid tagging more than 3 people.