Skip to content

Fix loops in eval.py #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2024
Merged

Fix loops in eval.py #128

merged 2 commits into from
May 4, 2024

Conversation

alexander-soare
Copy link
Contributor

@alexander-soare alexander-soare commented May 3, 2024 •
edited
Loading

  • Adds a condition check for whether to compile video frames.
  • Avoids updating the per-batch progress bar twice per loop iteration.

@alexander-soare alexander-soare requested a review from Cadene May 3, 2024 16:38
@alexander-soare alexander-soare changed the title Fix condition for rendering frames Fix minor bugs in eval.py May 3, 2024
@alexander-soare alexander-soare changed the title Fix minor bugs in eval.py Fix loops in eval.py May 3, 2024
Cadene
Cadene approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm

@alexander-soare alexander-soare merged commit d747195 into main May 4, 2024
@alexander-soare alexander-soare deleted the alexander-soare/fix_rendering_bug branch May 4, 2024 14:21
aliberts pushed a commit that referenced this pull request May 4, 2024
@alexander-soare @aliberts
Fix loops in eval.py (#128)
39c2eed
menhguin pushed a commit to menhguin/lerobot that referenced this pull request Feb 9, 2025
@alexander-soare
Fix loops in eval.py (huggingface#128)
83f2e14
Kalcy-U referenced this pull request in Kalcy-U/lerobot May 13, 2025
@alexander-soare
Fix loops in eval.py (#128)
d518a04
ZoreAnuj pushed a commit to luckyrobots/lerobot that referenced this pull request Jul 29, 2025
@alexander-soare
Fix loops in eval.py (huggingface#128)
bd46103
Ricci084 pushed a commit to JeffWang987/lerobot that referenced this pull request Sep 5, 2025
@alexander-soare
Fix loops in eval.py (huggingface#128)
9982684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Cadene Cadene Cadene approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-soare @Cadene