Skip to content

Fix V4L2 BGR24 handling #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

Thinner77
Copy link
Contributor

Summary

Hi,

this is a small bugfix for V4L2 grabber, a (virtual-)device with pixelformat set to BGR3 (=BGR24) wasn't usable because of mixup RGB24/BGR24 in code.

wbr

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@Lord-Grey
Copy link
Collaborator

Great that you spotted that one!

@Thinner77
Copy link
Contributor Author

Hi,

if you have some time, check MF grabber too, same issue, search for RGB24, but i don't know if it's a problem.

wbr

@Lord-Grey Lord-Grey merged commit 897e4aa into hyperion-project:master May 30, 2024
18 checks passed
@Thinner77 Thinner77 deleted the fix_v4l2_bgr24 branch May 31, 2024 12:57
@Lord-Grey Lord-Grey mentioned this pull request May 31, 2024
14 tasks
@Lord-Grey
Copy link
Collaborator

Hi,

if you have some time, check MF grabber too, same issue, search for RGB24, but i don't know if it's a problem.

wbr

@Thinner77 see #1749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants