RGB24 and BGR24 cleanup

[Lord-Grey]

Summary

• RGB24 / BGR24 / BGR16 on top of Fix V4L2 BGR24 handling #1748

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated (docs/docs/en)
• Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

• Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

[Thinner77]

Great! Can you also complete support for BGR16 and BGR32? Pixelformat.h and ImageResampler already know about these formats, so it's only adding some more "if"s in V4L2 gabber 😄.
wbr

PS: Looks like MF doesn't know about BGR-Formats: https://learn.microsoft.com/de-de/windows/win32/medfound/video-subtype-guids

[Lord-Grey]

Can you also complete support for BGR16 and BGR32?

Done.

It stepped away from BGR16, as I do not think a grey-scale format is too relevant and ImageResampler does not have a implementation yet.

Windows MF is now fixed, too.
Was a good opportunity to get my Windows dev environment up and running again 😀

[Thinner77]

Hi @Lord-Grey,

you are great, and fast 😄 .
But BGR16 isn't a grayscale format and ImageResampler already knows it, i'm confused:

hyperion.ng/libsrc/utils/ImageResampler.cpp

Line 120 in 76fff98

case PixelFormat::BGR16:

wbr

[Lord-Grey]

ImageResampler already knows it

I am sorry, I confused myself. I was referring to RGB16… :(
I will add it

Thanks for a 2nd pair of eyes reviewing!

[Thinner77]

Hi,

the other option would be to remove support for BGR16 completely because it hasn't been usable so far and nobody seems to have needed it. I don't know, it's your decision. ;-)

wbr

[Lord-Grey]

the other option would be to remove support for BGR16 completely because it hasn't been usable so far and nobody seems to have needed it.

I do not know if there are side effects on other grabbers.