[NFC][SYCL] Cache aspects that call has_extension
#18546
Conversation
That call requires string comparison which isn't trivial. On the other hand, querying supported extensions is going to happen anyway, so it makes sense to eagerly initialize everything extensions-related in the `device_impl` ctor.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Standalone reproducer(s) for what is supposedly an MSVC's bug: https://godbolt.org/z/s6bP6qK4f @StephanTLavavej could you please pass this to the MSVC compiler team? The reproducer is 100% standalone (<30 lines, no includes). Not going to go through MSFT account creation just to submit a bug report. |
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
I respectfully decline. I maintain the C++ Standard Library, not the compiler. I'll typically accept and file STL bug reports (with actionable repros, within reason) through any channel because they'll land on my desk anyways, but it's not my job to handle compiler bug reports. Because I love C++ so much, I occasionally spend extra time to submit or escalate compiler bug reports as a favor to the community, but I don't appreciate being expected to do so, just so you can save a little effort. It's not even optimal for me to report compiler bugs. The VS Developer Community site is set up to prioritize bug reports according to user votes and the account addresses of submitters. If you create an account with your work email address, bug reports will be given a significantly higher priority than anything I can submit, as counter-intuitive as that may seem. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Co-authored-by: Udit Kumar Agarwal <[email protected]>
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
That call requires string comparison which isn't trivial. On the other hand, querying supported extensions is going to happen anyway, so it makes sense to eagerly initialize everything extensions-related in the
device_implctor.