Skip to content

[NFC][SYCL] Cache aspects that call has_extension #18546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 21, 2025
Merged

[NFC][SYCL] Cache aspects that call has_extension #18546

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93b5962
[NFC][SYCL] Cache aspects that call `has_extension`
aelovikov-intel May 19, 2025
a4b2ab3
Try to fix Win build
aelovikov-intel May 19, 2025
6d32f47
Workaround another MSVC bug
aelovikov-intel May 20, 2025
7525044
Try to make MSVC happy in another place too
aelovikov-intel May 20, 2025
61679f5
Update sycl/source/detail/device_impl.hpp
aelovikov-intel May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try to make MSVC happy in another place too
  • Loading branch information
@aelovikov-intel
aelovikov-intel committed May 20, 2025
commit 7525044a1ba29aa66bfb85bf5432db4c89ded2ec
2 changes: 2 additions & 0 deletions sycl/source/detail/device_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1485,6 +1485,8 @@ class device_impl : public std::enable_shared_from_this<device_impl> {
#undef __SYCL_ASPECT_DEPRECATED
#undef __SYCL_ASPECT
}
assert(false && "Why doesn't has<aspect>() cover it?");
return false;
}

/// Queries SYCL queue for SYCL backend-specific information.
Expand Down