Skip to content

cache: use configured cache directory for fs cache path #10795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025

Conversation

italosestilon
Copy link
Contributor

@italosestilon italosestilon commented Jun 28, 2025

Instead of using the default cache directory, use the the configured one. This helps with importing large datasets.

Fixes #10794

Instead of using the default cache directory, use the the configured one. This helps with importing large datasets.

Fixes iterative#10794
@github-project-automation github-project-automation bot moved this to Backlog in DVC Jun 28, 2025
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (2431ec6) to head (ef03704).
Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10795      +/-   ##
==========================================
+ Coverage   90.68%   91.06%   +0.38%     
==========================================
  Files         504      504              
  Lines       39795    40264     +469     
  Branches     3141     3184      +43     
==========================================
+ Hits        36087    36668     +581     
+ Misses       3042     2965      -77     
+ Partials      666      631      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skshetry skshetry merged commit 0adf667 into iterative:main Jun 30, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in DVC Jun 30, 2025
@skshetry
Copy link
Collaborator

Thank you for contributing, @italosestilon.

I noticed this was added in #9969, which seems to have introduced this bug.

For future contributions, please avoid opening pull requests directly from your "main" branch. Here’s a helpful guide on why this is good practice. Thanks!

@skshetry skshetry added the bugfix fixes bug label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

import: fetch downloads data to default cache dir
2 participants